From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x235.google.com (mail-oi1-x235.google.com [IPv6:2607:f8b0:4864:20::235]) by sourceware.org (Postfix) with ESMTPS id E47B33858C54 for ; Wed, 8 Mar 2023 12:31:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E47B33858C54 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oi1-x235.google.com with SMTP id bh20so11995956oib.9 for ; Wed, 08 Mar 2023 04:31:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678278676; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=S+XUT/lW9VXD8nXZr0GGwMGiIL64I3Yuf35j6ihHzH0=; b=ATzu2JU9kAkkXkEcXTv1NTk8GfJdV194N012IyflRIS0Bvv53qAZFpTHzAI80k6Iw6 fWmq9WDEiN28Wa+vCzaNCIr9AErIy5NJpOBMgOuF2g/VYndLwfkSqWf9dSup5Lxd9Pbo H67hmjOwl/mfUf0qFDRCCJGgM5tQPyhDh4+iLJTJXw2LmqU0oZz5WByhtBMX1XncjEju gJdHb8Esw70m/InZ7rcvklp0qyK4EgzpwERwFflJhigbslvz8CSn44rHBIPKFuHN13TH XgxvRQEZzjHnve1ykEps8lRNCcvRxGZze3dLY2BhCEn5k+U3hOGQdjmzS9vhMSYRIdIV rh0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678278676; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=S+XUT/lW9VXD8nXZr0GGwMGiIL64I3Yuf35j6ihHzH0=; b=SSHNOc1gc8wRv+M4s9xZTQ8qyUkJA207hJ5JPXuHhtJ45/9lpLoNojOMLxhZgYVyNp Iau7HmEQyQaK/ZsdRfvhH7m3t8DREqoYZqoPKozOzqr4tSfJPUh3UBMX/wjHeloSdGxs YUo/X/p+bsLakXzCHmrxkf74u+tUC1LffqKKpMtqdrOW0iAJh6PgRsHW9rHUFGwq0jfh 0uiqhjwOovUWBVbiZNVZYoyosjpP/32RI8Gplw//QScLHU6davvo+XXB3f9eN6MjxLXf ZzSPQiPAv+7+VMauUBpBXPtoljJpcHJ1Ly9XnSw5gXsAstMZkQou2NyNgJ7Glm9eh746 wd9w== X-Gm-Message-State: AO0yUKVkheHl752Sq0Gkdu5Glpb8U3ZaQyNVM5c3KliOkZ19q44Fwgk5 LnCSI98Xtn+CtBM/rXVpOgEzgDBZT4cUj/3mxATlYw== X-Google-Smtp-Source: AK7set93NKtvZn2uo+j5TB9c5SYKXy1HDVrzACWJfaPMYuJ1ntUzlN0NxG6kl/g1ZU7V5rJ/FhrUkQ== X-Received: by 2002:aca:1b11:0:b0:384:115f:ed44 with SMTP id b17-20020aca1b11000000b00384115fed44mr7834746oib.46.1678278675617; Wed, 08 Mar 2023 04:31:15 -0800 (PST) Received: from ?IPV6:2804:1b3:a7c0:544b:655d:5559:758d:90f7? ([2804:1b3:a7c0:544b:655d:5559:758d:90f7]) by smtp.gmail.com with ESMTPSA id l7-20020acabb07000000b003845000eca7sm6347306oif.1.2023.03.08.04.31.14 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Mar 2023 04:31:14 -0800 (PST) Message-ID: <18bac4b1-2729-efc7-c529-3f79bf79a34b@linaro.org> Date: Wed, 8 Mar 2023 09:31:12 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v2] linux: fix ntp_gettime abi break Content-Language: en-US To: libc-alpha@sourceware.org References: <87bkl3seeg.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <87bkl3seeg.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 08/03/23 07:53, Florian Weimer via Libc-alpha wrote: > * Kacper Piwiński via Libc-alpha: > >> From 57cfc759e3982ad591cf4d8c5f3392daf3799b3f Mon Sep 17 00:00:00 2001 >> From: =?UTF-8?q?Kacper=20Piwi=C5=84ski?= >> Date: Wed, 8 Mar 2023 10:14:16 +0100 >> Subject: [PATCH v2] linux: fix ntp_gettime abi break >> >> Resolves #30156 > > Could you please reference the commit(s) which introduced the ABI change > in the commit message? You can use your initial commit message: -- Between versions v2.11 and v2.12 struct ntptimeval got new fields. That wasn't a problem because new function ntp_gettimex was created (and made default) to support new struct. Old ntp_gettime was not using new fields so it was safe to call with old struct definition. Then commits 5613afe9e3dff and b6ad64b907a (added for 64 bit time_t support), ntp_gettime start setting new fields. Sets fields manually to maintain compatibility with v2.11 struct definition. --