From: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
To: libc-alpha@sourceware.org, Andreas Schwab <schwab@linux-m68k.org>
Subject: Re: [PATCH v2] wchar: Define va_list for POSIX (BZ #30035)
Date: Wed, 22 Mar 2023 10:11:21 -0300 [thread overview]
Message-ID: <18ef4af7-d89d-01a7-628b-7287679eec06@linaro.org> (raw)
In-Reply-To: <61890062-04b1-d709-abf3-ede0ba32bd0e@linaro.org>
Ping (x2).
On 09/02/23 16:43, Adhemerval Zanella Netto wrote:
> Ping.
>
> On 24/01/23 14:49, Adhemerval Zanella wrote:
>> This was uncovered by a recent clang change [1]. Different than ISO C,
>> POSIX states that va_list should be exported by wchar.h [2].
>>
>> Checked on x86_64-linux-gnu and aarch64-linux-gnu.
>>
>> [1] https://reviews.llvm.org/D137268
>> [2] https://pubs.opengroup.org/onlinepubs/9699919799.2018edition/basedefs/wchar.h.html
>> ---
>> conform/data/wchar.h-data | 3 +++
>> wcsmbs/wchar.h | 11 +++++++++++
>> 2 files changed, 14 insertions(+)
>>
>> diff --git a/conform/data/wchar.h-data b/conform/data/wchar.h-data
>> index e414651a33..0af74e14bc 100644
>> --- a/conform/data/wchar.h-data
>> +++ b/conform/data/wchar.h-data
>> @@ -15,6 +15,9 @@ type size_t
>> type locale_t
>> # endif
>> tag {struct tm}
>> +# if !defined ISO99 && !defined ISO11 && !defined UNIX98
>> +type va_list
>> +# endif
>>
>> function wint_t btowc (int)
>> function int fwprintf (FILE*, const wchar_t*, ...)
>> diff --git a/wcsmbs/wchar.h b/wcsmbs/wchar.h
>> index 69e920b8c2..ca145bb8d2 100644
>> --- a/wcsmbs/wchar.h
>> +++ b/wcsmbs/wchar.h
>> @@ -37,6 +37,17 @@
>> #define __need___va_list
>> #include <stdarg.h>
>>
>> +#if defined __USE_XOPEN2K || defined __USE_XOPEN2K8
>> +# ifdef __GNUC__
>> +# ifndef _VA_LIST_DEFINED
>> +typedef __gnuc_va_list va_list;
>> +# define _VA_LIST_DEFINED
>> +# endif
>> +# else
>> +# include <stdarg.h>
>> +# endif
>> +#endif
>> +
>> #include <bits/wchar.h>
>> #include <bits/types/wint_t.h>
>> #include <bits/types/mbstate_t.h>
next prev parent reply other threads:[~2023-03-22 13:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-24 17:49 Adhemerval Zanella
2023-02-09 19:43 ` Adhemerval Zanella Netto
2023-03-22 13:11 ` Adhemerval Zanella Netto [this message]
2023-05-25 14:30 ` Adhemerval Zanella Netto
2023-05-25 15:15 ` Andreas Schwab
2023-05-25 16:43 ` Adhemerval Zanella Netto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18ef4af7-d89d-01a7-628b-7287679eec06@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).