public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Stefan Liebler <stli@linux.vnet.ibm.com>
To: libc-alpha@sourceware.org
Subject: Re: [PATCH] S390: Clobber also r14 in TLS_LD, TLS_GD macros on 31bit.
Date: Tue, 04 Apr 2017 11:19:00 -0000	[thread overview]
Message-ID: <18efe25e-a055-dd47-c360-48604002e0aa@linux.vnet.ibm.com> (raw)
In-Reply-To: <57fbfd70-e620-b60a-3eaa-1ae52182cbc8@linux.vnet.ibm.com>

On 04/03/2017 03:50 PM, Stefan Liebler wrote:
> On 03/29/2017 11:22 AM, Stefan Liebler wrote:
>> Hi,
>>
>> This patch also clobbers r14 in TLS_LD, TLS_GD macros on 31bit.
>> This ensures that r14 isn't used to save and restore r12 while
>> r14 is clobbered by the bas-instruction.
>>
>> As note:
>> r12 can't be clobbered as gcc would fail with:
>> error: PIC register clobbered by ‘12’ in ‘asm’
>>
>> For 64bit this fix was already done in 2004 in the
>> commit b80af23ac6973e69df6cd23d221fa44fffb21e17.
>>
>> Bye
>> Stefan
>>
>> ChangeLog:
>>
>>     * sysdeps/s390/s390-32/tls-macros.h (TLS_LD, TLS_GD):
>>     Clobber also r14.
>
> Any objection?
> Otherwise, I'll commit it tomorrow.
>
> Bye
> Stefan
>
Committed.

      reply	other threads:[~2017-04-04 11:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-29  9:23 Stefan Liebler
2017-04-03 13:50 ` Stefan Liebler
2017-04-04 11:19   ` Stefan Liebler [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18efe25e-a055-dd47-c360-48604002e0aa@linux.vnet.ibm.com \
    --to=stli@linux.vnet.ibm.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).