From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 71727 invoked by alias); 13 Jul 2018 07:03:31 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 71249 invoked by uid 89); 13 Jul 2018 07:03:30 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-10.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Subject: Re: [PATCH v8 1/8] nptl: Add C11 threads thrd_* functions To: Adhemerval Zanella , Szabolcs Nagy , libc-alpha@sourceware.org Cc: nd@arm.com References: <1517591084-11347-1-git-send-email-adhemerval.zanella@linaro.org> <1517591084-11347-2-git-send-email-adhemerval.zanella@linaro.org> <23dd1909-5ec2-34b7-9672-827251a4be65@redhat.com> <176c958e-45d6-c1fc-49e4-4eca813d460f@linaro.org> <0566f5a5-f56c-7dd9-5ba6-91c67d9633e9@arm.com> <1fdcdd41-5160-f6db-e585-9775e5b581c3@linaro.org> <52af7901-3974-5f7a-5dfd-fed2d5785fe9@linaro.org> From: Florian Weimer Message-ID: <1943c185-ad97-c102-9eb8-04ecbb545d6d@redhat.com> Date: Fri, 13 Jul 2018 07:03:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <52af7901-3974-5f7a-5dfd-fed2d5785fe9@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-SW-Source: 2018-07/txt/msg00360.txt.bz2 On 07/12/2018 07:38 PM, Adhemerval Zanella wrote: > > > On 12/07/2018 09:18, Florian Weimer wrote: >> On 07/11/2018 06:24 PM, Adhemerval Zanella wrote: >>> >>> >>> On 11/07/2018 12:49, Szabolcs Nagy wrote: >>>> On 10/07/18 20:26, Adhemerval Zanella wrote: >>>>> >>>>> >>>>> On 06/07/2018 09:46, Florian Weimer wrote: >>>>>> On 02/02/2018 06:04 PM, Adhemerval Zanella wrote: >>>>>>> @@ -139,7 +139,9 @@ libpthread-routines = nptl-init vars events version pt-interp \ >>>>>>>                   pthread_mutex_getprioceiling \ >>>>>>>                   pthread_mutex_setprioceiling \ >>>>>>>                   pthread_setname pthread_getname \ >>>>>>> -              pthread_setattr_default_np pthread_getattr_default_np >>>>>>> +              pthread_setattr_default_np pthread_getattr_default_np \ >>>>>>> +              thrd_create thrd_current thrd_detach thrd_equal \ >>>>>> >>>>>> thrd_current should live in libc, not in libpthread.  Same for thrd_equal, I suppose.  You should just duplicate the comparison, seeing that we haven't done that particular cleanup for pthread_equal yet. >>>>>> >>>>>> Not sure about thrd_sleep and thrd_yield, but I lean towards libc there as well. >>>>> >>>>> Right, I added all four symbols (thrd_current, thrd_equal, thrd_sleep, and >>>>> thrd_yield) to libc on my personal branch [1] (the change is just to move >>>>> the objects from libpthread-routines to routines rule in nptl/Makefile). >>>>> I also adjusted the abilist patch with the change. >>>>> >>>> >>>> the abilist patch seems to add >>>> sysdeps/unix/sysv/linux/tile/tilegx64/libpthread.abilist >>>> i think you can drop that (and update the ChangeLog). >>> >>> Thanks for catching this up, I fixed on my personal c11 thread branch. >> >> I still see the attached ABI diffs. > > Thanks, I have corrected them in my personal branch, along with the ChangeLog > entry and a lingering file from tile. As of commit 2b9d7c41ade511d99cd917bb8d28eb0fe91971ed, I still see: ==> /home/bmg/build/glibcs/mipsel-linux-gnu-nan2008-soft/glibc/elf/check-abi-libc.out <== --- ../sysdeps/unix/sysv/linux/mips/mips32/nofpu/libc.abilist 2018-07-10 08:15:53.536227638 -0400 +++ /home/bmg/build/glibcs/mipsel-linux-gnu-nan2008-soft/glibc/libc.symlist 2018-07-13 03:00:06.345221784 -0400 @@ -1963,0 +1964,4 @@ GLIBC_2.28 statx F +GLIBC_2.28 thrd_current F +GLIBC_2.28 thrd_equal F +GLIBC_2.28 thrd_sleep F +GLIBC_2.28 thrd_yield F ==> /home/bmg/build/glibcs/mipsel-linux-gnu-soft/glibc/elf/check-abi-libc.out <== --- ../sysdeps/unix/sysv/linux/mips/mips32/nofpu/libc.abilist 2018-07-10 08:15:53.536227638 -0400 +++ /home/bmg/build/glibcs/mipsel-linux-gnu-soft/glibc/libc.symlist 2018-07-13 02:58:41.692589329 -0400 @@ -1963,0 +1964,4 @@ GLIBC_2.28 statx F +GLIBC_2.28 thrd_current F +GLIBC_2.28 thrd_equal F +GLIBC_2.28 thrd_sleep F +GLIBC_2.28 thrd_yield F ==> /home/bmg/build/glibcs/mips-linux-gnu-nan2008-soft/glibc/elf/check-abi-libc.out <== --- ../sysdeps/unix/sysv/linux/mips/mips32/nofpu/libc.abilist 2018-07-10 08:15:53.536227638 -0400 +++ /home/bmg/build/glibcs/mips-linux-gnu-nan2008-soft/glibc/libc.symlist 2018-07-13 03:00:43.831389053 -0400 @@ -1963,0 +1964,4 @@ GLIBC_2.28 statx F +GLIBC_2.28 thrd_current F +GLIBC_2.28 thrd_equal F +GLIBC_2.28 thrd_sleep F +GLIBC_2.28 thrd_yield F ==> /home/bmg/build/glibcs/mips-linux-gnu-soft/glibc/elf/check-abi-libc.out <== --- ../sysdeps/unix/sysv/linux/mips/mips32/nofpu/libc.abilist 2018-07-10 08:15:53.536227638 -0400 +++ /home/bmg/build/glibcs/mips-linux-gnu-soft/glibc/libc.symlist 2018-07-13 03:00:32.210027180 -0400 @@ -1963,0 +1964,4 @@ GLIBC_2.28 statx F +GLIBC_2.28 thrd_current F +GLIBC_2.28 thrd_equal F +GLIBC_2.28 thrd_sleep F +GLIBC_2.28 thrd_yield F Florian