From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-87262-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 101447 invoked by alias); 18 Nov 2017 15:22:55 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 101438 invoked by uid 89); 18 Nov 2017 15:22:55 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=BAYES_00,KB_WAM_FROM_NAME_SINGLEWORD,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:845, HTo:D*canonical.com
X-HELO: mx1.redhat.com
Subject: Re: [PATCH v2] support_become_root: Don't fail when
 /proc/<pid/setgroups is missing
To: Christian Brauner <christian.brauner@canonical.com>
Cc: Christian Brauner <christian.brauner@ubuntu.com>,
 libc-alpha@sourceware.org
References: <20171118151311.20305-1-christian.brauner@ubuntu.com>
 <5966e5a2-240f-66db-88b3-71ecaad1028f@redhat.com>
 <20171118151922.eci4hca4dknmuv3p@gmail.com>
From: Florian Weimer <fweimer@redhat.com>
Message-ID: <1962a795-4b54-2784-bb5f-6f7bc1eb5fe5@redhat.com>
Date: Sat, 18 Nov 2017 15:22:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <20171118151922.eci4hca4dknmuv3p@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2017-11/txt/msg00637.txt.bz2

On 11/18/2017 04:19 PM, Christian Brauner wrote:
> On Sat, Nov 18, 2017 at 04:15:41PM +0100, Florian Weimer wrote:
>> On 11/18/2017 04:13 PM, Christian Brauner wrote:
>>> The requirement to write "deny" to/proc/<pid>/setgroups for a given user
>>> namespace before being able to write a gid mapping was introduced in Linux
>>> 3.19.  Before that this requirement including the file did not exist.
>>> So don't fail when errno == ENOENT.
>>>
>>> Signed-off-by: Christian Brauner<christian.brauner@ubuntu.com>
>>
>> glibc uses an FSF copyright assignment and not the DCO, so this line is
>> misleading.
> 
> Right, I'm removing it. It gets auto-added due to my .gitconfig. :)

Please consider disabling this in .git/config for the glibc checkout.

Thanks,
Florian