From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x543.google.com (mail-ed1-x543.google.com [IPv6:2a00:1450:4864:20::543]) by sourceware.org (Postfix) with ESMTPS id DF79E393C879 for ; Fri, 25 Sep 2020 12:01:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org DF79E393C879 Received: by mail-ed1-x543.google.com with SMTP id n13so2190331edo.10 for ; Fri, 25 Sep 2020 05:01:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:cc:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=mSDaHY0Eww4j7ztCmj0v8JLSjWgMgis3u1pFFFPuiww=; b=tK5ddpxEfWS+4B2Kd2g3ujXIWMRzagfvQjBegFJ+HAizCeBwExgBlR3jFJiqK5lVpM DICim3K1gr8bFXq5jgJirZycDNXFYEcYP4WXa/SK7+zZ+F1jKGfuDIKqxbp8nIa3/sGC 51rzPtxL4t31IEVJQPul+3D89kpS4CfioiHDsK5QwfSCkgfmeq2jJ+xZG20ON6sR2aWW tKK/qsxM1pj4ErLcUNuzxyrb/S99HHd+er0EWejzQBLT0/T9GNFBNV5Ze3I3QRHmYN59 a5ovi7sJpXz9jJmrIsFV6ltJ49+VTTv10iaM7db8iqIOu7LKzVYLZQhf9ANEzPfE6iNv 9EFg== X-Gm-Message-State: AOAM533wVm8tnZngpmnujG1IJ+Hk+nGiM3Lgu9I4/XeyQs/66fw225Nl uefxXtkkVJFv6nZWDCgKVcuTfzEjq34= X-Google-Smtp-Source: ABdhPJzhjhMPDj9yqSI8zwhpN0/ihk4eIuoPW5X9/RyZFdv/6y9AiKp4iZ3MDM7A6ovla1XjnAw32A== X-Received: by 2002:a50:f1cf:: with SMTP id y15mr933508edl.204.1601035285668; Fri, 25 Sep 2020 05:01:25 -0700 (PDT) Received: from ?IPv6:2001:a61:2479:6801:d8fe:4132:9f23:7e8f? ([2001:a61:2479:6801:d8fe:4132:9f23:7e8f]) by smtp.gmail.com with ESMTPSA id o15sm1728917ejr.1.2020.09.25.05.01.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Sep 2020 05:01:24 -0700 (PDT) Cc: mtk.manpages@gmail.com, linux-man@vger.kernel.org, libc-alpha@sourceware.org Subject: Re: [PATCH v2 04/10] system_data_types.7: Add float_t To: Alejandro Colomar References: <94936b66-4d20-1168-546f-64ac63018845@gmail.com> <20200925111922.222149-1-colomar.6.4.3@gmail.com> From: "Michael Kerrisk (man-pages)" Message-ID: <19cc7c28-7cca-7197-aecd-a4d529f3df6d@gmail.com> Date: Fri, 25 Sep 2020 14:01:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200925111922.222149-1-colomar.6.4.3@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_ASCII_DIVIDERS, KAM_SHORT, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Sep 2020 12:01:28 -0000 Hi Alex, On 9/25/20 1:19 PM, Alejandro Colomar wrote: > Signed-off-by: Alejandro Colomar > --- > > Hi Michael, > > On 2020-09-25 11:30, Michael Kerrisk (man-pages) wrote: >>> I removed the "intended" part to simplify it a bit. Do you prefer to >>> keep it? >> Well, as long as you are going to lift the detail about "most >> efficient" from the C standard, I'd be inclined to keep >> the word "intended" from the standard as well. But I do not feel >> strongly about it. >> > > Fair enough. > > > On 2020-09-25 11:30, Michael Kerrisk (man-pages) wrote: >>> BTW, I'll also add a note that FLT_EVAL_METHOD is defined in >>> Would you add that to "Notes", or as part of the description? >> As part of the description I think. (And I don't mind if it's >> repeated in the double_t description.) > > I think there was a misunderstanding; maybe I should have been clearer: > > I meant to write about in the "Notes" of the type, > and not in the "NOTES" of the entire page. Okay -- got it now. > > However, I decided to do it in the description of the type as you said, > because it was a bit simpler. > > The other version would have resulted in this code, just for you to see: I think the path you took was better. I've applied the patch and done some very light editing. Thanks, Michael > > [[ > .TP > .I double_t > .RS > .PP > Include: > .IR . > .PP > The implementation's most efficient floating type at least as wide as > .IR double . > Its type depends on the value of the macro > .BR FLT_EVAL_METHOD : > .TP > 0 > .I double_t > is > .IR double . > .TP > 1 > .I double_t > is > .IR double . > .TP > 2 > .I double_t > is > .IR "long double" . > .IP > For other values of > .BR FLT_EVAL_METHOD , > the type of > .I double_t > is implementation-defined. > .PP > Conforming to: C99 and later; POSIX.1-2001 and later. > .PP > Notes: The macro > .B FLT_EVAL_METHOD > is defined in > .IR . > .PP > See also the > .I float_t > type in this page. > .RE > ]] > > > Cheers, > > Alex > > man7/system_data_types.7 | 42 ++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 42 insertions(+) > > diff --git a/man7/system_data_types.7 b/man7/system_data_types.7 > index b04457bbf..aa5ab95e9 100644 > --- a/man7/system_data_types.7 > +++ b/man7/system_data_types.7 > @@ -147,6 +147,48 @@ Conforming to: C99 and later; POSIX.1-2001 and later. > .IP > See also: > .BR fenv (3) > +.\"------------------------------------- float_t ----------------------/ > +.TP > +.I float_t > +.IP > +Include: > +.IR . > +.IP > +The implementation's most efficient floating type at least as wide as > +.IR float . > +Its type depends on the value of the macro > +.BR FLT_EVAL_METHOD , > +defined in > +.IR : > +.RS > +.TP > +0 > +.I float_t > +is > +.IR float . > +.TP > +1 > +.I float_t > +is > +.IR double . > +.TP > +2 > +.I float_t > +is > +.IR "long double" . > +.IP > +For other values of > +.BR FLT_EVAL_METHOD , > +the type of > +.I float_t > +is implementation-defined. > +.RE > +.IP > +Conforming to: C99 and later; POSIX.1-2001 and later. > +.IP > +See also the > +.I double_t > +type in this page. > .\"------------------------------------- gid_t ------------------------/ > .TP > .I gid_t > -- Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ Linux/UNIX System Programming Training: http://man7.org/training/