From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 88608 invoked by alias); 21 Oct 2016 21:49:15 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 88596 invoked by uid 89); 21 Oct 2016 21:49:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy= X-HELO: mail-ua0-f175.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=s4vh65h4/gBrlWxmnrDa8uWSETmLbEU8uN3u8YcTGno=; b=KUGSX0iF4okiNmmS3dUxTYYIZD1kAG9OSxDuSejNADngP8hSIqeBtwNM8qQUgahisr /EN3bXCd77ObD/Y8zoiQ9iGnXPQ6wHvEVMQgs4FS/i2lsLOsU4J8nwbeszA69FUeY8rD VaxfgzaIZQEjR3WP2n0LF1bV6L/5FPGFpcaYYo9pR04abR9mDgncHIkJcK27drnSrpA6 k09jKoPkN+G3Rk/3BXUB8QqCujauhOCY0JCB6mKT6wuE1YvE9J2M+Jz22lHK8XsK090c X4We49KXavoZrfI/et7Ce+3yBoJuemKKWV1N+bNFNMOWplGyc6+4Hpp/kpL9W0rBjUl/ M+UQ== X-Gm-Message-State: ABUngvegh48oU6bP2+adN3wHNioM/txlhJlBkXViHzwbUOTYfopIzwAkiAv7EILU3CHXdP9F X-Received: by 10.159.39.227 with SMTP id b90mr1406658uab.87.1477086542496; Fri, 21 Oct 2016 14:49:02 -0700 (PDT) Subject: Re: [PATCH] powerpc: Fix TOC stub on powerpc64 clone() To: libc-alpha@sourceware.org References: <1477083962-9894-1-git-send-email-tuliom@linux.vnet.ibm.com> From: Adhemerval Zanella Message-ID: <19f97efa-5eae-9caa-8917-7b87f6092a4c@linaro.org> Date: Fri, 21 Oct 2016 21:49:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <1477083962-9894-1-git-send-email-tuliom@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-10/txt/msg00373.txt.bz2 LGTM, it follows what GCC generated for non retur functions. I am assuming you actually tested on powerpc64. On 21/10/2016 19:06, Tulio Magno Quites Machado Filho wrote: > Use a function call to _exit() so that the linker can create a TOC stub > instead of just a branch. > > 2016-10-21 Tulio Magno Quites Machado Filho > > [BZ #20728] > * sysdeps/unix/sysv/linux/powerpc/powerpc64/clone.S: Replace a > branch to _exit() by a function call. > --- > sysdeps/unix/sysv/linux/powerpc/powerpc64/clone.S | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sysdeps/unix/sysv/linux/powerpc/powerpc64/clone.S b/sysdeps/unix/sysv/linux/powerpc/powerpc64/clone.S > index 7c59b9b..df824f5 100644 > --- a/sysdeps/unix/sysv/linux/powerpc/powerpc64/clone.S > +++ b/sysdeps/unix/sysv/linux/powerpc/powerpc64/clone.S > @@ -97,7 +97,7 @@ L(oldpid): > #ifdef SHARED > b JUMPTARGET(__GI__exit) > #else > - b JUMPTARGET(_exit) > + bl JUMPTARGET(_exit) > /* We won't ever get here but provide a nop so that the linker > will insert a toc adjusting stub if necessary. */ > nop >