From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 3351D3858409 for ; Mon, 5 Feb 2024 14:15:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3351D3858409 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3351D3858409 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.158.5 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707142543; cv=none; b=Khwn2fJzkDi7xhnlG6qcTDdkBDm0lmczo3R1+11Rw6LLsu85zQ9D9WOfho/L4FCDmfbOimmLmY2RechboGaNQ5S7SvG9LuG+wFjSmBjiZhUYe9086hR5xIwkzPIAwCZ8Awsg0omlPbXaQCZQRyNab0MW4UKp/30EmVywjv7tohU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707142543; c=relaxed/simple; bh=lYRBmLkl31aorTRqRD0cj99R2op3a3TR7+LiBrmVA+8=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=CgOgnVDqvDq7xgzvJtlTkuhX69okO83y57mFfyGQCGoJCEwYC6F627kmh/vrfiJ6JH72Tcg6kvtJt4h0z1fTAxAkevuBkJmeCWQH7CvNoKKtys4mDx+0j9hCoy9JYkhk+SAxJhrkaC/dcOL2qMo2QpPrcuHGV2+9EXaEp7VZFpo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0353722.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 415E5Oko002804; Mon, 5 Feb 2024 14:15:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : subject : to : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pp1; bh=6OkpFXDNXLFcDPCTc8auoJZnQIHpEQYETte+YVRYtdI=; b=XUHEX+pQYT1EocJ/nYP61vMghZsnwrcf1tjjheCL31jVxguufTh3xOmKam4oMS6+ryMI /Xl5AomRdfHBXwgPXV1lNqYXIly/CB0ErNA7PD+UMeuRzXPU9lf0hbU16juF7QG2jIeM cgE+IHL/2dB1eOfJIvth4g/spjmgK/p35Wa6Xyom5f6dQBcMMQWr4raGz0ic1mW6CeA4 MAg5GtyqBL9dPnUMPs0sGcUkoFHHXmHLVRg1hrqiE+4oOIOfxF22GthM6iAAbLwtC4/o d8xo6IFcW1NpPOFbPZREFGm/ZuqPnQC+w8Ci7D0rWtEOLl3v/pyM6qWDhQEzMl90NUBn 2A== Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3w30ngschy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 05 Feb 2024 14:15:40 +0000 Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 415DlVSk014778; Mon, 5 Feb 2024 14:15:40 GMT Received: from smtprelay05.fra02v.mail.ibm.com ([9.218.2.225]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3w20tngvxc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 05 Feb 2024 14:15:40 +0000 Received: from smtpav03.fra02v.mail.ibm.com (smtpav03.fra02v.mail.ibm.com [10.20.54.102]) by smtprelay05.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 415EFceO18678444 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 5 Feb 2024 14:15:38 GMT Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3425F20043; Mon, 5 Feb 2024 14:15:38 +0000 (GMT) Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1A97820040; Mon, 5 Feb 2024 14:15:38 +0000 (GMT) Received: from [9.152.222.232] (unknown [9.152.222.232]) by smtpav03.fra02v.mail.ibm.com (Postfix) with ESMTP; Mon, 5 Feb 2024 14:15:38 +0000 (GMT) Message-ID: <1a1c8a1a-7d96-42cb-b16f-387ca6c810ea@linux.ibm.com> Date: Mon, 5 Feb 2024 15:15:36 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Fix stringop-overflow warning in tst-strlcat2. Content-Language: en-US To: Adhemerval Zanella Netto , libc-alpha@sourceware.org References: <20240116084430.1082389-1-stli@linux.ibm.com> <162bd443-2625-4179-8f34-cca94cacac38@linaro.org> From: Stefan Liebler In-Reply-To: <162bd443-2625-4179-8f34-cca94cacac38@linaro.org> Content-Type: text/plain; charset=UTF-8 X-TM-AS-GCONF: 00 X-Proofpoint-GUID: P6TC-UUrGHNvlaCXtJJJMJWCLT6hj-Do X-Proofpoint-ORIG-GUID: P6TC-UUrGHNvlaCXtJJJMJWCLT6hj-Do Content-Transfer-Encoding: 8bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-05_08,2024-01-31_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 lowpriorityscore=0 malwarescore=0 priorityscore=1501 mlxlogscore=751 phishscore=0 adultscore=0 impostorscore=0 spamscore=0 bulkscore=0 clxscore=1015 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2402050108 X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 05.02.24 14:53, Adhemerval Zanella Netto wrote: > > > On 16/01/24 05:44, Stefan Liebler wrote: >> On s390x, I get warnings like this when do_one_test is inlined with SIZE_MAX: >> In function ‘do_one_test’, >> inlined from ‘do_overflow_tests’ at tst-strlcat2.c:184:2: >> tst-strlcat2.c:49:18: error: ‘strnlen’ specified bound [18446744073709550866, 18446744073709551615] exceeds maximum object size 9223372036854775807 [-Werror=stringop-overflow=] >> 49 | # define STRNLEN strnlen >> | ^ >> tst-strlcat2.c:89:23: note: in expansion of macro ‘STRNLEN’ >> 89 | size_t dst_length = STRNLEN (dst, n); >> | ^~~~~~~ >> >> This patch just marks the do_one_test function as noinline as also done in test-strncat.c: >> Fix stringop-overflow warning in test-strncat. >> https://sourceware.org/git/?p=glibc.git;a=commit;h=51aeab9a363a0d000d0912aa3d6490463a26fba2 > > LGTM, although I am not seeing this failure with gcc 13.2.1 on x86_64 > nor on s390x (building with -Os). > Thanks and committed. Yes, you are right. The recent gcc's on s390x does not inline so much as with older versions. If I remember correctly, starting with gcc 10, inlining was reduced (for s390x).