From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x82e.google.com (mail-qt1-x82e.google.com [IPv6:2607:f8b0:4864:20::82e]) by sourceware.org (Postfix) with ESMTPS id 0021D3858D35 for ; Wed, 22 Dec 2021 20:20:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0021D3858D35 Received: by mail-qt1-x82e.google.com with SMTP id o17so3044805qtk.1 for ; Wed, 22 Dec 2021 12:20:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=b3cvfmQ1aazSj/qls2DVKyKp4XZTPtx0c1hcgA/WatY=; b=qMwdU9gXD+34YNEj2piuaGSxAfgaJBTd3WUOXwnNw2JmxyYcYg3fUAV2vdYmLKsDah rykDEy6OWCwD26eASV7lqqAgVKprla7O2TN1FUhk6eyWweLa6d65/T+63p261LsFPECw +1QGOEHpecuVVSyuoXSd9kFWpa0Pg99qZ25G02czlbH7SPEpE94tqr7F0hCS8tU4IxnK yu9ch4XuwPeIl86Z2nLPhPxAHle1vbVJHBod5f+FslBqZbKjRAHihNOJgJs0T3PouFuq OpOBAZvbyw9fe9rhR9spAOS07/d06rz5wdKxeF1joZy31GdLmK6snaGnznYnimX2iRvo axYA== X-Gm-Message-State: AOAM533A4L1jhNsf4FtQf6O9gn5cXejHkrJu0OkKyxBV9ebxxRZpOed9 MfHnsmOQhJlTYnbb4yMewxIoFQ== X-Google-Smtp-Source: ABdhPJxVOVxvgiPNgutBQsO3Eq9CGEuvbGYzII435WKc9QGn537+LmtF8rf3nnZmVZcp0Cb+x0MW6Q== X-Received: by 2002:ac8:4e8a:: with SMTP id 10mr3494892qtp.578.1640204413176; Wed, 22 Dec 2021 12:20:13 -0800 (PST) Received: from ?IPV6:2804:431:c7cb:3b1e:1ba8:c11f:6224:efe1? ([2804:431:c7cb:3b1e:1ba8:c11f:6224:efe1]) by smtp.gmail.com with ESMTPSA id e17sm2437255qtw.18.2021.12.22.12.20.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Dec 2021 12:20:12 -0800 (PST) Message-ID: <1a46b8a6-87dd-b811-fd82-0292ea575935@linaro.org> Date: Wed, 22 Dec 2021 17:20:10 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH v3 10/13] or1k: ABI lists Content-Language: en-US To: Stafford Horne , GLIBC patches , Florian Weimer Cc: Openrisc References: <20211210233456.4146479-1-shorne@gmail.com> <20211210233456.4146479-11-shorne@gmail.com> From: Adhemerval Zanella In-Reply-To: <20211210233456.4146479-11-shorne@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Dec 2021 20:20:15 -0000 On 10/12/2021 20:34, Stafford Horne via Libc-alpha wrote: > diff --git a/sysdeps/unix/sysv/linux/or1k/ld.abilist b/sysdeps/unix/sysv/linux/or1k/ld.abilist > new file mode 100644 > index 0000000000..c4b85c8a33 > --- /dev/null > +++ b/sysdeps/unix/sysv/linux/or1k/ld.abilist > @@ -0,0 +1,5 @@ > +GLIBC_2.35 __libc_stack_end D 0x4 > +GLIBC_2.35 __stack_chk_guard D 0x4 > +GLIBC_2.35 __tls_get_addr F > +GLIBC_2.35 _dl_mcount F > +GLIBC_2.35 _r_debug D 0x14 You will need to regenerate it to include the rseq symbols: GLIBC_2.35 __rseq_flags D 0x4 GLIBC_2.35 __rseq_offset D 0x4 GLIBC_2.35 __rseq_size D 0x4 > diff --git a/sysdeps/unix/sysv/linux/or1k/libBrokenLocale.abilist b/sysdeps/unix/sysv/linux/or1k/libBrokenLocale.abilist > new file mode 100644 > index 0000000000..366c393274 > --- /dev/null > +++ b/sysdeps/unix/sysv/linux/or1k/libBrokenLocale.abilist > @@ -0,0 +1 @@ > +GLIBC_2.35 __ctype_get_mb_cur_max F > diff --git a/sysdeps/unix/sysv/linux/or1k/libanl.abilist b/sysdeps/unix/sysv/linux/or1k/libanl.abilist > new file mode 100644 > index 0000000000..c6437809db > --- /dev/null > +++ b/sysdeps/unix/sysv/linux/or1k/libanl.abilist > @@ -0,0 +1 @@ > +GLIBC_2.35 __libanl_version_placeholder F This does seems right, or1k should not require the placeholder. I think we are missing a SHLIB_COMPAT on resolv/libanl-compat.c: diff --git a/resolv/libanl-compat.c b/resolv/libanl-compat.c index 29df76f278..02c18bde90 100644 --- a/resolv/libanl-compat.c +++ b/resolv/libanl-compat.c @@ -30,6 +30,8 @@ __libanl_version_placeholder_1 (void) { } +# if SHLIB_COMPAT (libanl, GLIBC_2_2_3, GLIBC_2_34) compat_symbol (libanl, __libanl_version_placeholder_1, __libanl_version_placeholder, GLIBC_2_2_3); +# endif #endif > diff --git a/sysdeps/unix/sysv/linux/or1k/libutil.abilist b/sysdeps/unix/sysv/linux/or1k/libutil.abilist > new file mode 100644 > index 0000000000..f33b84813b > --- /dev/null > +++ b/sysdeps/unix/sysv/linux/or1k/libutil.abilist > @@ -0,0 +1 @@ > +GLIBC_2.35 __libutil_version_placeholder F This also does not seems right, libutil-compat will only built for have-GLIBC_2.33, which is not the case.