From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from butterfly.birch.relay.mailchannels.net (butterfly.birch.relay.mailchannels.net [23.83.209.27]) by sourceware.org (Postfix) with ESMTPS id 5BD043857738 for ; Tue, 18 Apr 2023 12:51:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5BD043857738 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gotplt.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 069F98C16B6; Tue, 18 Apr 2023 12:51:44 +0000 (UTC) Received: from pdx1-sub0-mail-a307.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 8AF5E8C0D14; Tue, 18 Apr 2023 12:51:43 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1681822303; a=rsa-sha256; cv=none; b=OmGkAnAOWc8bbAFAxZlN9Aqz1FarZMjAeP+OjKBnHCdiNdYjBiT0MJfFCOLfA4Rij7fC2F mFQHmbcA70e34n22cKp770greJXTFt/NcdLb1WNhTlNPsK0ZZAt2ij83VUREJLqsZ4XTWB bj4YSJ119xc1dxOOXf/JajKxv/Pbc1yUTVJKMkieuk6I81CeKp9RMvlT2XPLe1oPsrTbMM XaES3fXcPw2FUwqhJeFrGo0fLn/iM7X8gIJvE4xezYjMJ9V+7wiMLRvos6Sk2uPX/SbMRg 0WWk7xLQcKZa8t09+CQ73k4+uSpLcOxc6XkDKXdtgBR3Dv3CZt/8cwJrAQd1/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1681822303; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VdrP+edit1rvn/wVi5MWYphn9EYOsvjDtWYQNMPdSj8=; b=AeqWMme1c33ArVeMv9H0DvQ5zHHaCVh7SLyldYVF8Gsm0PUqWSdKxThcMwT/vdLB1DVxTh 5KdPxS2D6y/Ga2b/09TRR6KTJYXRvy6N7z454a8ja1ad6iShl7/DIhWkGE9lu5+cwdCrck OxiP80IOoAMjwtmnUdpIItXlk+yDd4mHgSSI/kEXiOwUoYTGpIVcn3wKOJcs4WCSCEhSkQ o45zIThASmLS+rkeFedxYqHfKWiuWohd++VHPhfir/Q/ZM35NOTp1+M4Om99FJCwLzeRKz rZs7ubibd8dVx7v0OYbGpMI+GuT8omX6YMYeHR/o+55TpfM0K4vyIyDEUthtwg== ARC-Authentication-Results: i=1; rspamd-548d6c8f77-bbt8n; auth=pass smtp.auth=dreamhost smtp.mailfrom=siddhesh@gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Arithmetic-Little: 099c579f2847ddc6_1681822303856_2199751746 X-MC-Loop-Signature: 1681822303856:2705790319 X-MC-Ingress-Time: 1681822303855 Received: from pdx1-sub0-mail-a307.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.97.48.96 (trex/6.7.2); Tue, 18 Apr 2023 12:51:43 +0000 Received: from [192.168.2.12] (unknown [174.91.45.80]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a307.dreamhost.com (Postfix) with ESMTPSA id 4Q13hZ4LkHzNm; Tue, 18 Apr 2023 05:51:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gotplt.org; s=dreamhost; t=1681822302; bh=VdrP+edit1rvn/wVi5MWYphn9EYOsvjDtWYQNMPdSj8=; h=Date:Subject:From:To:Cc:Content-Type:Content-Transfer-Encoding; b=Ecm7qrxbiiLu4hRnUJMurKNRVGcfaA/RU2rmqbr9NBpfDo8bEkX9J/+7tv8lnXyPv R4OZly/wnPm8RWKlSalLaCbEV8v4OB0MFyQ3QeHyjcEuq/cXgsz+H47asEtT8joDr2 4YfhSKxGNkP9HpJW/Ttzn27ObtWxmSQ93Vz4eb1uxbGEAj4w5hkDqG6BPiThxHN67m kb2SrHFFCS5ghQ47EdrmXK2DwZN62Xuhv6HmNGaYkpVt43l5QtVeeb4Tx0c0T8tj6V 8pHkP2xlZm96Rgoadh19Pnuc2laZ9vRRsyrMH536OB66CpjEXk66QIfp0pAisK4sMs 242z8zMKmkWXg== Message-ID: <1a821e6c-0c44-f7cc-7732-296ac5181e02@gotplt.org> Date: Tue, 18 Apr 2023 08:51:31 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH 6/8] nptl_db/thread_dbP.h: fix warn unused result Content-Language: en-US From: Siddhesh Poyarekar To: =?UTF-8?B?RnLDqWTDqXJpYyBCw6lyYXQ=?= , libc-alpha@sourceware.org Cc: sipoyare@redhat.com References: <20230418121130.844302-1-fberat@redhat.com> <20230418121130.844302-7-fberat@redhat.com> <8bb20739-865d-0c99-31c5-cdbcdd91dc46@gotplt.org> In-Reply-To: <8bb20739-865d-0c99-31c5-cdbcdd91dc46@gotplt.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3038.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-04-18 08:49, Siddhesh Poyarekar wrote: > On 2023-04-18 08:11, Frédéric Bérat via Libc-alpha wrote: >> Fix unused result warnings, detected when _FORTIFY_SOURCE is enabled in >> glibc. >> --- >>   nptl_db/thread_dbP.h | 2 +- >>   1 file changed, 1 insertion(+), 1 deletion(-) > > LGTM. > > Reviewed-by: Siddhesh Poyarekar > >> >> diff --git a/nptl_db/thread_dbP.h b/nptl_db/thread_dbP.h >> index 8845722109..ad0c197f6f 100644 >> --- a/nptl_db/thread_dbP.h >> +++ b/nptl_db/thread_dbP.h >> @@ -61,7 +61,7 @@ enum >>   /* Comment out the following for less verbose output.  */ >>   #ifndef NDEBUG >> -# define LOG(c) if (__td_debug) write (2, c "\n", strlen (c "\n")) >> +# define LOG(c) if (__td_debug) assert(write (2, c "\n", strlen (c >> "\n")) == strlen (c "\n")) Ahh wait, missing space after assert. >>   extern int __td_debug attribute_hidden; >>   #else >>   # define LOG(c) >