public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Siddhesh Poyarekar <siddhesh@sourceware.org>
To: libc-alpha@sourceware.org
Subject: [PING][PATCH] show_archive_content: Fix trivial memory leak
Date: Mon, 17 May 2021 21:29:12 +0530	[thread overview]
Message-ID: <1aa29a78-71d4-7375-46fb-86863da388e8@sourceware.org> (raw)
In-Reply-To: <20210511171738.360327-1-siddhesh@sourceware.org>

Ping!  I'll push this in a couple of days if there are no objections 
since it is a pretty trivial fix.

Siddhesh

On 5/11/21 10:47 PM, Siddhesh Poyarekar via Libc-alpha wrote:
> Fix trivial leak identified by coverity.  The program runs to exit and
> the leak doesn't grow, but it's just cleaner to free the allocated
> memory.
> ---
>   locale/programs/locarchive.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/locale/programs/locarchive.c b/locale/programs/locarchive.c
> index 6bb189ae37..f38e835c52 100644
> --- a/locale/programs/locarchive.c
> +++ b/locale/programs/locarchive.c
> @@ -1742,6 +1742,7 @@ show_archive_content (const char *fname, int verbose)
>   			: locnames[idx]);
>   	      }
>   	}
> +      free (files);
>       }
>     else
>       for (cnt = 0; cnt < used; ++cnt)
> 


  reply	other threads:[~2021-05-17 15:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-11 17:17 [PATCH] " Siddhesh Poyarekar
2021-05-17 15:59 ` Siddhesh Poyarekar [this message]
2021-05-17 17:04 ` Adhemerval Zanella

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1aa29a78-71d4-7375-46fb-86863da388e8@sourceware.org \
    --to=siddhesh@sourceware.org \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).