From: Jeff Law <law@redhat.com>
To: Szabolcs Nagy <szabolcs.nagy@arm.com>,
Florian Weimer <fweimer@redhat.com>,
Andreas Schwab <schwab@suse.de>
Cc: nd@arm.com, Carlos O'Donell <carlos@redhat.com>,
Paul Eggert <eggert@cs.ucla.edu>,
libc-alpha@sourceware.org
Subject: Re: [PATCH] Add the statx function
Date: Wed, 11 Jul 2018 13:44:00 -0000 [thread overview]
Message-ID: <1bbe8097-b923-a434-798c-3f548db7edc3@redhat.com> (raw)
In-Reply-To: <9f8fcf2b-a075-a390-90a5-d8f5cd38f65c@arm.com>
On 07/11/2018 04:01 AM, Szabolcs Nagy wrote:
> On 11/07/18 07:55, Florian Weimer wrote:
>> On 07/11/2018 08:53 AM, Andreas Schwab wrote:
>>> /usr/include/sys/stat.h:446:11: fatal error: bits/statx.h: No such
>>> file or directory
>>> Â # include <bits/statx.h>
>>> Â Â Â Â Â Â Â Â Â Â Â ^~~~~~~~~~~~~~
>>
>> Okay, so this file should be an installed header. I will commit a fix
>> after testing.
>>
>> Any idea why our header tests do not catch this?
>>
>
> because the glibc source tree does have bits/statx.h
> and all tests (incorrectly) run with internal headers
> in the include path (not just the installed ones).
>
> build-many-glibcs.py catches it though when building gcc
> (i've just run into this).
My testers started tripping over this yesterday on various platforms.
jeff
next prev parent reply other threads:[~2018-07-11 13:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-30 22:41 Florian Weimer
2018-07-02 9:01 ` Andreas Schwab
2018-07-05 18:36 ` Paul Eggert
2018-07-05 18:59 ` Florian Weimer
2018-07-05 19:06 ` Carlos O'Donell
2018-07-07 23:23 ` Paul Eggert
2018-07-10 9:16 ` Florian Weimer
2018-07-10 12:14 ` Carlos O'Donell
2018-07-10 14:19 ` Florian Weimer
2018-07-11 6:53 ` Andreas Schwab
2018-07-11 6:55 ` Florian Weimer
2018-07-11 10:01 ` Szabolcs Nagy
2018-07-11 13:44 ` Jeff Law [this message]
2018-07-26 15:16 ` Florian Weimer
2018-07-26 19:38 ` Andreas Schwab
2018-07-26 21:16 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1bbe8097-b923-a434-798c-3f548db7edc3@redhat.com \
--to=law@redhat.com \
--cc=carlos@redhat.com \
--cc=eggert@cs.ucla.edu \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=nd@arm.com \
--cc=schwab@suse.de \
--cc=szabolcs.nagy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).