From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x82e.google.com (mail-qt1-x82e.google.com [IPv6:2607:f8b0:4864:20::82e]) by sourceware.org (Postfix) with ESMTPS id C27C0394341D for ; Fri, 11 Jun 2021 15:08:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C27C0394341D Received: by mail-qt1-x82e.google.com with SMTP id o20so2790263qtr.8 for ; Fri, 11 Jun 2021 08:08:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=0HMYH4SA0VrkQcRqGEnqhtdzoUrFY3VLw5xeahdfRpY=; b=OkW+REkmoyiw/45zCQ3+XA9uxN+gq0/CqbKQ6balGeisxNfXvF3egzA/RtgOYajKpv ntgLEIcxam1oBzIuTgmcsDTaRXfdXZMNbL9bzz+2C+QSz2TmI4w1BTkGVz7w0xdvPUyQ v/6CEpcGTYzSBgwo1vmR5pvyciMsGMiYxFZ4oYF89mVIf761Vgf5D3+IU2byUHUGUBZn jP8QBwmwVHUdu6E/6YaJ0vqBUr61eOaq9lXqtVid0vTG5Ur/ZkbUzyNxqsv3lvxKMgYn JP1BA7qKCs+g6wjRecLwx9ITg5P4BZgBGJ2ulkTVNUFiqjSvC87aTGXnXLU1l9rLehlO Rm5Q== X-Gm-Message-State: AOAM531m3hfU4xKvyP5CguMX4EeLAzlrtSJPPaHIIpbp2Fy4ZM4dlnej CtC5vugoLYYFuaa3VQg586DsM39AMGiZJg== X-Google-Smtp-Source: ABdhPJyvMIPlaTaL4bQXfb/B9sg/aEJv1ZjcIunNZJeJyQ4lQVSkUHLhlfY8rb7LSzylEVUUctCFhQ== X-Received: by 2002:ac8:6e8e:: with SMTP id c14mr4212593qtv.216.1623424083767; Fri, 11 Jun 2021 08:08:03 -0700 (PDT) Received: from [192.168.1.4] ([177.194.59.218]) by smtp.gmail.com with ESMTPSA id h19sm4392043qtq.5.2021.06.11.08.08.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Jun 2021 08:08:03 -0700 (PDT) Subject: Re: [PATCH 1/6] nptl: Fix tst-cancel7 and tst-cancelx7 race condition (BZ #14232) To: Florian Weimer , Adhemerval Zanella via Libc-alpha References: <20210610193639.3650754-1-adhemerval.zanella@linaro.org> <20210610193639.3650754-2-adhemerval.zanella@linaro.org> <87a6nwsave.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella Message-ID: <1bcee05d-d043-3393-f040-49a3e0825da9@linaro.org> Date: Fri, 11 Jun 2021 12:08:00 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <87a6nwsave.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2021 15:08:06 -0000 On 11/06/2021 12:02, Florian Weimer wrote: > * Adhemerval Zanella via Libc-alpha: > >> +static const char sem_name[] = "/tst-cancel7-sem"; > > I don't think this is valid, it will break with concurrent execution of > the test suite from different build trees. > > Maybe you could use support_shared_allocate and sem_init with a > process-shared semaphore? Indeed I did not take this in consideration. But support_shared_allocate is similar to the unnamed semaphore and the test will use a system() to spawn the test process. So support_shared_allocate does not really help here. Maybe a better option would be to move to test-container.