From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f]) by sourceware.org (Postfix) with ESMTPS id 119823858D37 for ; Thu, 26 Oct 2023 13:14:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 119823858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 119823858D37 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::62f ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698326057; cv=none; b=Im8Ej+8MuUTHO7qZjtWAFn7EnkBegI9rwLwpQz/wH2nbqHbR8YYLcDH8BfM/Fvdx02H1mG2gdU4c9pZ0kQqBdbr13MCenZOHGXgTBgayOYEmqcG1NiZlTtWeK7738M8FAJyrmWDxdEJb6rSYuAADOHoows4ch0RjzIHvMofeJfk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698326057; c=relaxed/simple; bh=GPoJOXFxSEPG/VI2Dujw2ryJXUU4AMlaj5RL02+ZK3o=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=xlTk2IbYare7H+IriTSy8esuIAvDxySmiPWaFh72DlMxHWM/nkyWLtKzaO67mElbzI0KISqwwPRvw/rITRGx0FoSPFlOr3QzUh/galD2yliCLPReF5AQw1JUzeu2vF4Zxwos9Wj9+5jSgjdmjd5oc1AxLB5uZUDYoTRv9kxWdrg= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x62f.google.com with SMTP id d9443c01a7336-1c8a1541232so7630575ad.0 for ; Thu, 26 Oct 2023 06:14:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1698326055; x=1698930855; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=j40B8edQPivaPPYQJOrNC3f+AOUQkB5dIANkRtYYODE=; b=jfbslEaE9Mamlq3NNq7L/lzybv40GK6DjmUSa7IppGv6saYz5xX160gHutBmz2gN+7 DF55+a3UP7Wo2GI94uH2Zzy08dyibSm/Vh0SQpbfpg56QhKti+8eqhLhHdonm0wEpU2E hjUfJ8vPsH2RgMJfO5vhLTsamYYbqfgfzcwsYUQ057gUUDxt4pULGxj+/DMMdkNvu7UB a6JhCk+6AE9Y0TlPkqbw8Q6tA8lqa3xs04cHCB82Ad6SYa2KLofxiJOKeSOTB7iBhiZ2 bd56tnJm38LaXzYNqUInqIq5+KAgDvlKcvY9DSOoM4oxJ2XAUyOGpvjdEliuy8ctmXCP D6Tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698326055; x=1698930855; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=j40B8edQPivaPPYQJOrNC3f+AOUQkB5dIANkRtYYODE=; b=nJ763Cqrw/ipxzF2/l2i/2NjHgDX6YkSmD+bIaQoeyuSMM4wz3Mke5ONandyZ8WI7F DjJ+2giXHafQ0B4qSB69L3hzyJJ4BVa2XSN7LB5ZwWamug9U8boG1pfrpiqj52EwaIQc /bOODuBdVUmgasqc1ZNHK+tvC/zj46a+KK4H6MO/lTSqJ3kMl0CVQw3svzgJIO1cvQ00 OFcvWRHIiwlg9sFYmtWEyXSrHTpXHV06ti1N/4nRMjbMovn+DvDJYXHn50Ctk1H0haju fCVh0HIek4ALrMuw8TUsZk9Ss0KyHuID03a4wstj6iXdr8vdIt6+Q0pPIHCI3hCj3IZZ Pejg== X-Gm-Message-State: AOJu0YxuFwUnApI7qzMMUCaY8bgmNqiP6NFcAfRi5QNtyVuKJzfX1ptC m98vcXXY5I4Do9Z2PvKvx3RwbdlVsn3eIX+h7VYcag== X-Google-Smtp-Source: AGHT+IH/SOTNXZR/dImy/nz9FfcKhzkDHqLY43hcAZ8IbhClR/NoNRPXeuEaosH0a3VMvdNcG0ZOMQ== X-Received: by 2002:a17:902:f550:b0:1ca:7086:60f7 with SMTP id h16-20020a170902f55000b001ca708660f7mr20757855plf.28.1698326055023; Thu, 26 Oct 2023 06:14:15 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c3:a647:f440:5502:d530:fccd? ([2804:1b3:a7c3:a647:f440:5502:d530:fccd]) by smtp.gmail.com with ESMTPSA id u8-20020a170902e5c800b001bc2831e1a8sm10906480plf.80.2023.10.26.06.14.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Oct 2023 06:14:14 -0700 (PDT) Message-ID: <1bfe6997-0232-4f47-ad73-9898523defd8@linaro.org> Date: Thu, 26 Oct 2023 10:14:12 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] LoongArch: Unify Register Names. Content-Language: en-US To: caiyinyu , libc-alpha@sourceware.org Cc: xry111@xry111.site References: <20231026130135.3670541-1-caiyinyu@loongson.cn> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <20231026130135.3670541-1-caiyinyu@loongson.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 26/10/23 10:01, caiyinyu wrote: > --- > sysdeps/loongarch/__longjmp.S | 20 ++++++++++---------- > sysdeps/loongarch/setjmp.S | 18 +++++++++--------- > 2 files changed, 19 insertions(+), 19 deletions(-) > > diff --git a/sysdeps/loongarch/__longjmp.S b/sysdeps/loongarch/__longjmp.S > index cbde1946a0..e87ce31194 100644 > --- a/sysdeps/loongarch/__longjmp.S > +++ b/sysdeps/loongarch/__longjmp.S > @@ -43,18 +43,18 @@ ENTRY (__longjmp) > REG_L s8, a0, 12*SZREG > > #ifndef __loongarch_soft_float > - FREG_L $f24, a0, 13*SZREG + 0*SZFREG > - FREG_L $f25, a0, 13*SZREG + 1*SZFREG > - FREG_L $f26, a0, 13*SZREG + 2*SZFREG > - FREG_L $f27, a0, 13*SZREG + 3*SZFREG > - FREG_L $f28, a0, 13*SZREG + 4*SZFREG > - FREG_L $f29, a0, 13*SZREG + 5*SZFREG > - FREG_L $f30, a0, 13*SZREG + 6*SZFREG > - FREG_L $f31, a0, 13*SZREG + 7*SZFREG > + FREG_L fs0, a0, 13*SZREG + 0*SZFREG > + FREG_L fs1, a0, 13*SZREG + 1*SZFREG > + FREG_L fs2, a0, 13*SZREG + 2*SZFREG > + FREG_L fs3, a0, 13*SZREG + 3*SZFREG > + FREG_L fs4, a0, 13*SZREG + 4*SZFREG > + FREG_L fs5, a0, 13*SZREG + 5*SZFREG > + FREG_L fs6, a0, 13*SZREG + 6*SZFREG > + FREG_L fs7, a0, 13*SZREG + 7*SZFREG > #endif > > - sltui a0,a1,1 > + sltui a0, a1, 1 > ADD a0, a0, a1 # a0 = (a1 == 0) ? 1 : a1 > - jirl zero,ra,0 > + jirl zero, ra, 0 > These both seems superfluous and I think we should avoid such changes since they just make harder to follow git blame. > END (__longjmp) > diff --git a/sysdeps/loongarch/setjmp.S b/sysdeps/loongarch/setjmp.S > index 6c7065cdbb..b6e4f727cd 100644 > --- a/sysdeps/loongarch/setjmp.S > +++ b/sysdeps/loongarch/setjmp.S > @@ -52,19 +52,19 @@ ENTRY (__sigsetjmp) > REG_S s8, a0, 12*SZREG > > #ifndef __loongarch_soft_float > - FREG_S $f24, a0, 13*SZREG + 0*SZFREG > - FREG_S $f25, a0, 13*SZREG + 1*SZFREG > - FREG_S $f26, a0, 13*SZREG + 2*SZFREG > - FREG_S $f27, a0, 13*SZREG + 3*SZFREG > - FREG_S $f28, a0, 13*SZREG + 4*SZFREG > - FREG_S $f29, a0, 13*SZREG + 5*SZFREG > - FREG_S $f30, a0, 13*SZREG + 6*SZFREG > - FREG_S $f31, a0, 13*SZREG + 7*SZFREG > + FREG_S fs0, a0, 13*SZREG + 0*SZFREG > + FREG_S fs1, a0, 13*SZREG + 1*SZFREG > + FREG_S fs2, a0, 13*SZREG + 2*SZFREG > + FREG_S fs3, a0, 13*SZREG + 3*SZFREG > + FREG_S fs4, a0, 13*SZREG + 4*SZFREG > + FREG_S fs5, a0, 13*SZREG + 5*SZFREG > + FREG_S fs6, a0, 13*SZREG + 6*SZFREG > + FREG_S fs7, a0, 13*SZREG + 7*SZFREG > #endif > > #if !IS_IN (libc) && IS_IN(rtld) > li.w v0, 0 > - jirl zero,ra,0 > + jirl zero, ra, 0 > #else > b __sigjmp_save > #endif