From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-x92f.google.com (mail-ua1-x92f.google.com [IPv6:2607:f8b0:4864:20::92f]) by sourceware.org (Postfix) with ESMTPS id B94833858037 for ; Thu, 11 Nov 2021 19:18:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B94833858037 Received: by mail-ua1-x92f.google.com with SMTP id p2so13974854uad.11 for ; Thu, 11 Nov 2021 11:18:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=gA/lkQe5i4wSY8oG3FrGWu3v39zu44VjbN7MCyrCrbE=; b=NnQS2d5O4FQS/98KyDf6S+geY6zXxUG1EZPshRpJ+MWdKNJuj5O9ahQvHVyu38++z2 epY56/q4pYEeDaPaVL+QIoRYVu6gbFKj8rHEtYCCyhE05Lho1PL8TbQph+lpgCBPhXYm JImia84qHDW0LGVEvn3TeQec6MybGhZMFPd8gLl8rqZQzf8kqBccW9nqfe8MJWoUHOoD rLKk8exzWmwGRY72vuemqnT++n+9Hz5WAl5TnpAaxzVAi0CyK9FXIVWG7aSK4KXgUZRe rbiIuFTDYSJS6+PnPNjD+d+tOC93cqLuVBQATOhHtCNwadUBnEqFxu8yH+DkRZqZTOdu zB8w== X-Gm-Message-State: AOAM532g3QnwQOKyLaWtqQXgGKo3u9cxbcyo2MA0W8jD1SCr4+ZUjUVy pMmuiZfgmwBxiQVlG5iHjhBVrw== X-Google-Smtp-Source: ABdhPJybc5dcVeCLdBf5Vjv6HttWAuaFGwOOnCvXFI15rEo/uwGUmQAtCZNrK2cVMzUfFLIAZ9O75Q== X-Received: by 2002:a05:6130:38e:: with SMTP id az14mr14443254uab.42.1636658315978; Thu, 11 Nov 2021 11:18:35 -0800 (PST) Received: from ?IPV6:2804:431:c7cb:55a:48f2:1d0b:8ae8:643a? ([2804:431:c7cb:55a:48f2:1d0b:8ae8:643a]) by smtp.gmail.com with ESMTPSA id bc18sm2586898vkb.34.2021.11.11.11.18.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Nov 2021 11:18:35 -0800 (PST) Message-ID: <1c4d980b-072b-c544-ba7a-3822b16625f5@linaro.org> Date: Thu, 11 Nov 2021 16:18:33 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.1 Subject: Re: [PATCH v5 02/22] elf: Add audit tests for modules with TLSDESC Content-Language: en-US To: Florian Weimer Cc: libc-alpha@sourceware.org, John Mellor-Crummey , Ben Woodard References: <20211109183347.2943786-1-adhemerval.zanella@linaro.org> <20211109183347.2943786-3-adhemerval.zanella@linaro.org> <87bl2s5d4b.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella In-Reply-To: <87bl2s5d4b.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-14.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Nov 2021 19:18:38 -0000 On 10/11/2021 10:55, Florian Weimer wrote: > * Adhemerval Zanella: > >> diff --git a/elf/Makefile b/elf/Makefile >> index bad18f2d11..bd1a0f79b4 100644 >> --- a/elf/Makefile >> +++ b/elf/Makefile >> @@ -384,6 +384,20 @@ modules-names += tst-gnu2-tls1mod >> $(objpfx)tst-gnu2-tls1: $(objpfx)tst-gnu2-tls1mod.so >> tst-gnu2-tls1mod.so-no-z-defs = yes >> CFLAGS-tst-gnu2-tls1mod.c += -mtls-dialect=gnu2 >> + >> +tests += tst-audit-tlsdesc tst-audit-tlsdesc-dlopen >> +modules-names += tst-auditmod-tlsdesc1 tst-auditmod-tlsdesc2 tst-audit-tlsdesc-audit >> +$(objpfx)tst-audit-tlsdesc: $(objpfx)tst-auditmod-tlsdesc1.so \ >> + $(objpfx)tst-auditmod-tlsdesc2.so \ >> + $(shared-thread-library) >> +CFLAGS-tst-auditmod-tlsdesc1.c += -mtls-dialect=gnu2 >> +CFLAGS-tst-auditmod-tlsdesc2.c += -mtls-dialect=gnu2 > > Do we need to check have-mtls-dialect-gnu2 here? It already does (line 387 above). > >> diff --git a/elf/tst-audit-tlsdesc-audit.c b/elf/tst-audit-tlsdesc-audit.c >> new file mode 100644 >> index 0000000000..53993830c9 >> --- /dev/null >> +++ b/elf/tst-audit-tlsdesc-audit.c > >> +unsigned int >> +la_version (unsigned int version) >> +{ >> + return version; >> +} > > Why not LAV_CURRENT? We should lead by good example. Ack.