From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.cs.ucla.edu (mail.cs.ucla.edu [131.179.128.66]) by sourceware.org (Postfix) with ESMTPS id D46713858D33 for ; Sun, 21 May 2023 08:19:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D46713858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=cs.ucla.edu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=cs.ucla.edu Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id 3A91E3C02213D; Sun, 21 May 2023 01:19:34 -0700 (PDT) Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id w4u1zlOlXwIX; Sun, 21 May 2023 01:19:32 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id 30F3A3C09FA29; Sun, 21 May 2023 01:19:32 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.cs.ucla.edu 30F3A3C09FA29 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.ucla.edu; s=9D0B346E-2AEB-11ED-9476-E14B719DCE6C; t=1684657172; bh=zw3Y2ULVDREqfOT/QgS8rLelROV4JBxYCxDjY+zDqtE=; h=Message-ID:Date:MIME-Version:To:From; b=U6+EJ6mlqWcihsbKxfP6kmhtUSA1zAtuc7H9RoKAUCiDI83y4ewJz+1mV8f5kuC6N 4KMF0uuDfu/v5dr6P26OYlAr/3CmMajq6tn0FbMD0cEpNDa4j8RLq+hd9c7L6Xxcbp rSyLnjFPg7XgeYUfdg6r5xG1juHk5YkD3hVtitTsk3kyWLazbwBtP25Xmy41wuAyo9 WPqdtmdbaRyCFipyw3p1pnUIEjdQLIugkmkaU6hX/roOYJmDstOWLOq+dB82FRaYFC PWAMSFBYgKrb/xvyBN6b4fJSeJKDy4SwsJrXqxkwK/N3nl2cZRt0xMY/ZGcJ1LmVRg whvkFAbcXb0Iw== X-Virus-Scanned: amavisd-new at mail.cs.ucla.edu Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id rRiYEvTPiiNS; Sun, 21 May 2023 01:19:32 -0700 (PDT) Received: from [192.168.1.9] (cpe-172-91-119-151.socal.res.rr.com [172.91.119.151]) by mail.cs.ucla.edu (Postfix) with ESMTPSA id EB0783C02213D; Sun, 21 May 2023 01:19:31 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------qSu1xRJMVsOfjMiIs5LNJ6Gv" Message-ID: <1c688849-f992-029e-30e8-8990c311c8a3@cs.ucla.edu> Date: Sun, 21 May 2023 01:19:28 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Content-Language: en-US To: Xi Ruoyao , lixing , Carlos O'Donell , Adhemerval Zanella Netto , Peng Fan Cc: "libc-alpha@sourceware.org" , ltp@lists.linux.it References: <0cb83efa85ae32d956f81e6b9d4966c38fd54bcb.camel@xry111.site> From: Paul Eggert Organization: UCLA Computer Science Department Subject: Re: [PATCH] Increase judgment on buf. In-Reply-To: <0cb83efa85ae32d956f81e6b9d4966c38fd54bcb.camel@xry111.site> X-Spam-Status: No, score=-8.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,GIT_PATCH_0,JMQ_SPF_NEUTRAL,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------qSu1xRJMVsOfjMiIs5LNJ6Gv Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable On 2023-05-20 03:19, Xi Ruoyao via Libc-alpha wrote: > If a LTP test relies on a EFAULT here, then LTP has a bug.=C2=A0 You sh= ould > tell LTP to fix it then. LTP fstat03 allows either EFAULT or SIGSEGV, but no other behavior, when=20 'stat' is passed a null pointer. Therefore that test is too strict for POSIX, as the POSIX behavior is=20 undefined. It's also too strict for GNU/Linux, because it insists on SIGSEGV=20 whereas any terminating signal will do (e.g., SIGABRT). Proposed LTP patch attached. --------------qSu1xRJMVsOfjMiIs5LNJ6Gv Content-Type: text/x-patch; charset=UTF-8; name="0001-fstat03-wrongly-required-SIGSEGV.patch" Content-Disposition: attachment; filename="0001-fstat03-wrongly-required-SIGSEGV.patch" Content-Transfer-Encoding: base64 RnJvbSA4YTJiM2Y3NWQyYjYxZTVlNGVjMGEyYzkzZjNkYjYyNTg0ZGFmMWNkIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBTdW4sIDIxIE1heSAyMDIzIDAxOjE1OjQwIC0wNzAwClN1YmplY3Q6IFtQQVRD SF0gZnN0YXQwMyB3cm9uZ2x5IHJlcXVpcmVkIFNJR1NFR1YKCkNoYW5nZSBmc3RhdDAzIHRv IGFsbG93IHRoZSBzeXNjYWxsIHRvIHNpZ25hbCBTSUdBQlJUIChvciBhbnkgb3RoZXIKc2ln bmFsKSBpbnN0ZWFkIG9mIFNJR1NFR1Ygd2hlbiBhIG51bGwgcG9pbnRlciBpcyBwYXNzZWQs IGFzIFBPU0lYCnNheXMgYmVoYXZpb3IgaXMgdW5kZWZpbmVkIGFuZCB0aGUgZ2xpYmMgYmVo YXZpb3IgKHdoaWNoIGlzIGEgYml0CmJldHRlciBkZWZpbmVkKSBjb3VsZCBiZSBhbnkgc2ln bmFsLCBub3QgbmVjZXNzYXJpbHkgU0lHU0VHVi4KClNpZ25lZC1vZmYtYnk6IFBhdWwgRWdn ZXJ0IDxlZ2dlcnRAY3MudWNsYS5lZHU+Ci0tLQogdGVzdGNhc2VzL2tlcm5lbC9zeXNjYWxs cy9mc3RhdC9mc3RhdDAzLmMgfCA2ICsrKy0tLQogMSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0 aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS90ZXN0Y2FzZXMva2VybmVs L3N5c2NhbGxzL2ZzdGF0L2ZzdGF0MDMuYyBiL3Rlc3RjYXNlcy9rZXJuZWwvc3lzY2FsbHMv ZnN0YXQvZnN0YXQwMy5jCmluZGV4IDRmZjM3ZTg4Mi4uYTQwMDY5MmU5IDEwMDY0NAotLS0g YS90ZXN0Y2FzZXMva2VybmVsL3N5c2NhbGxzL2ZzdGF0L2ZzdGF0MDMuYworKysgYi90ZXN0 Y2FzZXMva2VybmVsL3N5c2NhbGxzL2ZzdGF0L2ZzdGF0MDMuYwpAQCAtMTAsNyArMTAsNyBA QAogICogMSkgQ2FsbHMgZnN0YXQoKSB3aXRoIGNsb3NlZCBmaWxlIGRlc2NyaXB0b3IKICAq ICAgIC0+IEVCQURGCiAgKiAyKSBDYWxscyBmc3RhdCgpIHdpdGggYW4gaW52YWxpZCBhZGRy ZXNzIGZvciBzdGF0IHN0cnVjdHVyZQotICogICAgLT4gRUZBVUxUIChvciByZWNlaXZlIHNp Z25hbCBTSUdTRUdWKQorICogICAgLT4gRUZBVUxUIChvciByZWNlaXZlIHNpZ25hbCkKICAq LwogCiAjaW5jbHVkZSA8ZXJybm8uaD4KQEAgLTcwLDggKzcwLDggQEAgc3RhdGljIHZvaWQg cnVuKHVuc2lnbmVkIGludCB0Y19udW0pCiAJfQogCVNBRkVfV0FJVFBJRChwaWQsICZzdGF0 dXMsIDApOwogCi0JaWYgKHRjYXNlc1t0Y19udW1dLmV4cF9lcnIgPT0gRUZBVUxUICYmIFdU RVJNU0lHKHN0YXR1cykgPT0gU0lHU0VHVikgewotCQl0c3RfcmVzKFRQQVNTLCAiZnN0YXQo KSBmYWlsZWQgYXMgZXhwZWN0ZWQgd2l0aCBTSUdTRUdWIik7CisJaWYgKHRjYXNlc1t0Y19u dW1dLmV4cF9lcnIgPT0gRUZBVUxUICYmIFdJRlNJR05BTEVEKHN0YXR1cykpIHsKKwkJdHN0 X3JlcyhUUEFTUywgImZzdGF0KCkgZmFpbGVkIGFzIGV4cGVjdGVkIHdpdGggYSBzaWduYWwi KTsKIAkJcmV0dXJuOwogCX0KIAotLSAKMi4zOS4yCgo= --------------qSu1xRJMVsOfjMiIs5LNJ6Gv--