From: Siddhesh Poyarekar <siddhesh@gotplt.org>
To: Florian Weimer <fweimer@redhat.com>
Cc: libc-alpha@sourceware.org, Carlos O'Donell <carlos@redhat.com>
Subject: Re: [PATCH] Force building with -fno-common
Date: Fri, 9 Jul 2021 13:42:54 +0530 [thread overview]
Message-ID: <1c6cf8e1-d21e-74e0-82ca-9437d9b918eb@gotplt.org> (raw)
In-Reply-To: <87eec7kj3m.fsf@oldenburg.str.redhat.com>
On 7/9/21 1:35 PM, Florian Weimer wrote:
> * Siddhesh Poyarekar:
>
>> Carlos clarified that non-ABI changes are OK during the slushy freeze,
>> but you could wait on him for additional approval.
>>
>> I did a build on x86_64 to verify that the resulting binaries are
>> identical (since -fno-common should be nop for gcc11) but turns out
>> they're not. I haven't yet looked at the nature of the change since
>> they could be benign but it still was surprising.
>
> Line numbering changes in a few places, and that affects asserts.
Great, in that case, LGTM. +Carlos for RM approval since the code is
identical with newer gcc.
Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
next prev parent reply other threads:[~2021-07-09 8:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-08 10:27 Florian Weimer
2021-07-09 7:46 ` Siddhesh Poyarekar
2021-07-09 8:05 ` Florian Weimer
2021-07-09 8:12 ` Siddhesh Poyarekar [this message]
2021-07-09 18:05 ` Carlos O'Donell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c6cf8e1-d21e-74e0-82ca-9437d9b918eb@gotplt.org \
--to=siddhesh@gotplt.org \
--cc=carlos@redhat.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).