Re: [PATCH v4 4/6] linux: Add compatibility definitions to sys/prctl.h for MTE

[Siddhesh Poyarekar <siddhesh@gotplt.org>]

On 12/21/20 7:09 PM, Florian Weimer wrote:
> * Siddhesh Poyarekar:
> 
>> On 12/19/20 12:59 AM, Richard Earnshaw via Libc-alpha wrote:
>>> Older versions of the Linux kernel headers obviously lack support
>>> for
>>> memory tagging, but we still want to be able to build in support when
>>> using those (obviously it can't be enabled on such systems).
>>> The linux kernel extensions are made to the platform-independent
>>> header (linux/prctl.h), so this patch takes a similar approach.
>>> ---
>>>    sysdeps/unix/sysv/linux/sys/prctl.h | 18 ++++++++++++++++++
>>>    1 file changed, 18 insertions(+)
>>
>> Please put the additions into an architecture-specific
>> sysdeps/unix/sysv/linux/aarch64/sys/prctl.h and include_next this file
>> from there.
> 
> This does not work for an installed header.  A separate bits/ header is
> needed for such cases (if it is indeed required not to make the
> definitions generic, which is probably not the case here—that is,
> this part of Richard's patch can be used as-is).

Uff, indeed I didn't notice that it was an installed header.  This is OK 
as is then.

Thanks,
Siddhesh