From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cross.elm.relay.mailchannels.net (cross.elm.relay.mailchannels.net [23.83.212.46]) by sourceware.org (Postfix) with ESMTPS id 5960F3857815 for ; Mon, 21 Dec 2020 13:41:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5960F3857815 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gotplt.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=siddhesh@gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id BDC661E1483; Mon, 21 Dec 2020 13:41:38 +0000 (UTC) Received: from pdx1-sub0-mail-a74.g.dreamhost.com (100-105-161-17.trex.outbound.svc.cluster.local [100.105.161.17]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 506B61E16F5; Mon, 21 Dec 2020 13:41:38 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from pdx1-sub0-mail-a74.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.11); Mon, 21 Dec 2020 13:41:38 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Wiry-Whistle: 6b87d5687fe72b79_1608558098568_720743006 X-MC-Loop-Signature: 1608558098568:1288683525 X-MC-Ingress-Time: 1608558098568 Received: from pdx1-sub0-mail-a74.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a74.g.dreamhost.com (Postfix) with ESMTP id E83FA830A1; Mon, 21 Dec 2020 05:41:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gotplt.org; h=subject:to :cc:references:from:message-id:date:mime-version:in-reply-to :content-type:content-transfer-encoding; s=gotplt.org; bh=ZfGSy8 7EzyP2gmxmMGpK37GeJQQ=; b=F3w0gVMuoR5/Pb/lszY8ch2Q7k/JvuS9TFyHkv SUBVdZX9FF6oEtKwox9f7UCm467NrMDPmfjWVa7twm16zasEPjhEFPhfAspMkvjH wMytOSkE98OAQ9WpsCIaox6GMISt+N01fShGObmZ/0Y7deA8OSoo/EKd6CA1c7q/ kNo2U= Received: from [192.168.1.111] (unknown [1.186.101.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a74.g.dreamhost.com (Postfix) with ESMTPSA id 96E61830A2; Mon, 21 Dec 2020 05:41:34 -0800 (PST) Subject: Re: [PATCH v4 4/6] linux: Add compatibility definitions to sys/prctl.h for MTE To: Florian Weimer Cc: Richard Earnshaw , libc-alpha@sourceware.org References: <20201218192957.11035-1-rearnsha@arm.com> <20201218192957.11035-5-rearnsha@arm.com> <3257efec-348c-6047-8afd-c91c74e2d06e@gotplt.org> <87wnxbwa5c.fsf@oldenburg2.str.redhat.com> X-DH-BACKEND: pdx1-sub0-mail-a74 From: Siddhesh Poyarekar Message-ID: <1c8ddeb6-e417-dfc0-13c5-a0da455571bf@gotplt.org> Date: Mon, 21 Dec 2020 19:11:30 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <87wnxbwa5c.fsf@oldenburg2.str.redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Dec 2020 13:41:55 -0000 On 12/21/20 7:09 PM, Florian Weimer wrote: > * Siddhesh Poyarekar: >=20 >> On 12/19/20 12:59 AM, Richard Earnshaw via Libc-alpha wrote: >>> Older versions of the Linux kernel headers obviously lack support >>> for >>> memory tagging, but we still want to be able to build in support when >>> using those (obviously it can't be enabled on such systems). >>> The linux kernel extensions are made to the platform-independent >>> header (linux/prctl.h), so this patch takes a similar approach. >>> --- >>> sysdeps/unix/sysv/linux/sys/prctl.h | 18 ++++++++++++++++++ >>> 1 file changed, 18 insertions(+) >> >> Please put the additions into an architecture-specific >> sysdeps/unix/sysv/linux/aarch64/sys/prctl.h and include_next this file >> from there. >=20 > This does not work for an installed header. A separate bits/ header is > needed for such cases (if it is indeed required not to make the > definitions generic, which is probably not the case here=E2=80=94that i= s, > this part of Richard's patch can be used as-is). Uff, indeed I didn't notice that it was an installed header. This is OK=20 as is then. Thanks, Siddhesh