From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-74055-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 60718 invoked by alias); 25 Oct 2016 13:13:23 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 60698 invoked by uid 89); 25 Oct 2016 13:13:22 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=H*r:sk:18.2016
X-HELO: mail-ua0-f169.google.com
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20130820;
        h=x-gm-message-state:subject:to:references:cc:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding;
        bh=vwM1aVTbdnha8pUq72FF4/FtmyzWilxjVAfs4aSrGso=;
        b=OIsopsfTEPLa7+F/uSIgwLB1Zb2LntP0Zvw00W/DvXg+u98fzdloN3tyWz7Rj5Llog
         unJ38LJuqqY0ToNqYWYQE0n5sfU31GKkKdTBMUQlTqNfWVfv0Nha+ZgxYKF0UOwRe45F
         umqwBGtMaYkjbzFqWyqnHSThxxdJ//eBk9lI5MyiZy7N1eCJfz0y9RTP17h7DgHIFcuw
         H8Sgse/WgbrXsJFGEgMbaVrOIsK8/b4mHez7lZB5Msr1l52jXsYGTL1/mIZs6t+Rjr/H
         yYMy3P2r6K79viE65Cn7iujMlc+RA1n82nzvWavpYC4uDpTbqvzzwSKGU0C4oSUZtFcH
         5WXA==
X-Gm-Message-State: ABUngvcAIAJNGCaXSA74Q+QrB9yxaUU8eHX1ny6ruX4lkX0PPVel4UqZVsZHW7VRdDmJuRr0
X-Received: by 10.176.2.50 with SMTP id 47mr10575709uas.8.1477401190524;
        Tue, 25 Oct 2016 06:13:10 -0700 (PDT)
Subject: Re: [PATCH] Fix undefined behaviour inconsistent for strtok
To: Andreas Schwab <schwab@suse.de>
References: <1477393113-3845-1-git-send-email-adhemerval.zanella@linaro.org>
 <mvmy41ck6lu.fsf@hawking.suse.de>
 <385e684a-8101-fd26-d2ff-464515a2e88c@linaro.org>
 <mvmoa28k2mn.fsf@hawking.suse.de>
Cc: libc-alpha@sourceware.org
From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Message-ID: <1c969961-5ce7-8b73-bede-647263423d01@linaro.org>
Date: Tue, 25 Oct 2016 13:13:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.3.0
MIME-Version: 1.0
In-Reply-To: <mvmoa28k2mn.fsf@hawking.suse.de>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-SW-Source: 2016-10/txt/msg00415.txt.bz2



On 25/10/2016 10:57, Andreas Schwab wrote:
> On Okt 25 2016, Adhemerval Zanella <adhemerval.zanella@linaro.org> wrote:
> 
>> On 25/10/2016 09:31, Andreas Schwab wrote:
>>> On Okt 25 2016, Adhemerval Zanella <adhemerval.zanella@linaro.org> wrote:
>>>
>>>> 	* string/strtok.c (strtok): Return null is previous input is also
>>>
>>> s/is/if/
>>>
>>>> diff --git a/string/strtok.c b/string/strtok.c
>>>> index 7a4574d..5c4b309 100644
>>>> --- a/string/strtok.c
>>>> +++ b/string/strtok.c
>>>> @@ -40,8 +40,8 @@ STRTOK (char *s, const char *delim)
>>>>  {
>>>>    char *token;
>>>>  
>>>> -  if (s == NULL)
>>>> -    s = olds;
>>>> +  if ((s == NULL) && ((s = olds) == NULL))
>>>
>>> Please avoid assignment in an expression.  And the parens are redundant.
>>>
>>> Andreas.
>>>
>>
>> Right, with these fixes would it be acceptable?
> 
> I don't see much point in supporting invalid use of strtok.
> 
> Andreas.
> 

My point is just to add portability and align with other current
implementations.