From: Carlos O'Donell <carlos@redhat.com>
To: Joseph Myers <joseph@codesourcery.com>
Cc: Zack Weinberg <zackw@panix.com>, libc-alpha@sourceware.org
Subject: Re: [PATCH 06/13] Installed header hygiene (BZ#20366): Macros used in #if without checking whether they are defined.
Date: Wed, 21 Sep 2016 20:24:00 -0000 [thread overview]
Message-ID: <1c9c871d-0c7a-7149-9ec7-7721c927d238@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1609211956320.31180@digraph.polyomino.org.uk>
On 09/21/2016 03:59 PM, Joseph Myers wrote:
> On Wed, 21 Sep 2016, Carlos O'Donell wrote:
>
>> On 09/21/2016 02:05 PM, Joseph Myers wrote:
>>> On Wed, 21 Sep 2016, Carlos O'Donell wrote:
>>>
>>>> At a high level I would expect _LIBC to always be defined as either 0 or 1.
>>>
>>> _LIBC is effectively with external code, because it's used (with #if) in
>>> code shared by gnulib. So we can't change its semantics like that;
>>> defining to 0 with installed glibc would break building gnulib.
>>
>> Isn't that just a normal coordination issue with gnulib?
>
> No. It should be possible to build existing versions of GNU software, and
> other packages using gnulib, with new versions of glibc, without needing
> to wait possibly years for loads of packages to have new releases with
> updated gnulib. Occasionally a new glibc may break a few external
> packages and require coordination with them, but we shouldn't do things
> that would cause the sort of global breakage of most gnulib-using software
> that would result from changing the public _LIBC interface with external
> code.
You use the words "should" twice, which matches my expectation here, that
we would like it to work, but by coordinating with gnulib we might change
it in the future given a good enough reason. I call this a coordination
issue with gnulib.
In this situation I see no case to be made for changing _LIBC's behaviour.
I think we are both in agreement. Perhaps I sounded too cavalier in claiming
it was "just" a coordination issue.
--
Cheers,
Carlos.
next prev parent reply other threads:[~2016-09-21 20:24 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-30 1:17 [PATCH 00/13] Installed-header hygiene (BZ#20366) Zack Weinberg
2016-08-30 1:17 ` [PATCH 01/13] Installed-header hygiene (BZ#20366): obsolete BSD u_* types Zack Weinberg
2016-08-30 1:17 ` [PATCH 02/13] Installed-header hygiene (BZ#20366): manual fixups after mechanical change Zack Weinberg
2016-08-30 1:17 ` [PATCH 03/13] Installed-header hygiene (BZ#20366): missing inclusions A Zack Weinberg
2016-08-30 1:16 ` [PATCH 04/13] Installed-header hygiene (BZ#20366): missing inclusions B Zack Weinberg
2016-08-30 1:16 ` [PATCH 05/13] Installed header hygiene (BZ#20366): BYTE_ORDER macros Zack Weinberg
2016-08-30 1:17 ` [PATCH 06/13] Installed header hygiene (BZ#20366): Macros used in #if without checking whether they are defined Zack Weinberg
2016-08-30 1:17 ` [PATCH 07/13] Installed-header hygiene (BZ#20366): stack_t Zack Weinberg
2016-08-30 1:36 ` [PATCH 08/13] Installed-header hygiene (BZ#20366): time.h types Zack Weinberg
2016-08-30 1:17 ` [PATCH 09/13] Installed-header hygiene (BZ#20366): struct ifreq Zack Weinberg
2016-08-30 1:17 ` [PATCH 10/13] Installed-header hygiene (BZ#20366): struct ether_addr Zack Weinberg
2016-08-30 1:36 ` [PATCH 11/13] Installed-header hygiene (BZ#20366): struct osockaddr Zack Weinberg
2016-08-30 1:17 ` [PATCH 12/13] Installed-header hygiene (BZ#20366): Miscellaneous Zack Weinberg
2016-08-30 1:17 ` [PATCH 13/13] Installed header hygiene (BZ#20366): Test of installed headers Zack Weinberg
2016-08-30 1:28 ` Joseph Myers
2016-08-30 3:12 ` Zack Weinberg
2016-09-22 12:20 ` Zack Weinberg
2016-09-21 20:12 ` Carlos O'Donell
2016-09-21 19:53 ` [PATCH 12/13] Installed-header hygiene (BZ#20366): Miscellaneous Carlos O'Donell
2016-09-21 19:27 ` [PATCH 11/13] Installed-header hygiene (BZ#20366): struct osockaddr Carlos O'Donell
2016-09-21 19:26 ` [PATCH 10/13] Installed-header hygiene (BZ#20366): struct ether_addr Carlos O'Donell
2016-09-21 19:51 ` Carlos O'Donell
2016-09-21 20:33 ` Zack Weinberg
2016-09-21 19:15 ` [PATCH 09/13] Installed-header hygiene (BZ#20366): struct ifreq Carlos O'Donell
2016-08-30 17:10 ` [PATCH 08/13] Installed-header hygiene (BZ#20366): time.h types Joseph Myers
2016-09-21 19:04 ` Carlos O'Donell
2016-09-21 19:12 ` Zack Weinberg
2016-09-21 19:50 ` Carlos O'Donell
2016-09-21 19:50 ` [PATCH 07/13] Installed-header hygiene (BZ#20366): stack_t Carlos O'Donell
2016-09-21 18:02 ` [PATCH 06/13] Installed header hygiene (BZ#20366): Macros used in #if without checking whether they are defined Carlos O'Donell
2016-09-21 18:05 ` Joseph Myers
2016-09-21 18:41 ` Carlos O'Donell
2016-09-21 18:47 ` Paul Eggert
2016-09-21 19:09 ` Carlos O'Donell
2016-09-21 19:59 ` Joseph Myers
2016-09-21 20:24 ` Carlos O'Donell [this message]
2016-09-21 18:09 ` Zack Weinberg
2016-09-21 17:56 ` [PATCH 05/13] Installed header hygiene (BZ#20366): BYTE_ORDER macros Carlos O'Donell
2016-09-21 17:52 ` [PATCH 04/13] Installed-header hygiene (BZ#20366): missing inclusions B Carlos O'Donell
2016-08-30 1:23 ` [PATCH 03/13] Installed-header hygiene (BZ#20366): missing inclusions A Joseph Myers
2016-08-30 3:12 ` Zack Weinberg
2016-09-21 17:54 ` Carlos O'Donell
2016-09-21 17:52 ` Carlos O'Donell
2016-09-21 17:58 ` Joseph Myers
2016-09-21 18:22 ` Zack Weinberg
2016-09-21 18:43 ` Carlos O'Donell
2016-09-21 17:43 ` [PATCH 02/13] Installed-header hygiene (BZ#20366): manual fixups after mechanical change Carlos O'Donell
2016-08-30 1:22 ` [PATCH 01/13] Installed-header hygiene (BZ#20366): obsolete BSD u_* types Joseph Myers
2016-08-30 3:12 ` Zack Weinberg
2016-08-30 17:10 ` Joseph Myers
2016-09-21 17:41 ` Carlos O'Donell
2016-08-30 1:26 ` [PATCH 00/13] Installed-header hygiene (BZ#20366) Joseph Myers
2016-08-30 3:12 ` Zack Weinberg
2016-08-30 7:51 ` Andreas Schwab
2016-09-06 17:10 ` Zack Weinberg
2016-09-21 14:22 ` Zack Weinberg
2016-09-21 17:34 ` Carlos O'Donell
2016-09-21 17:52 ` Carlos O'Donell
2016-09-21 18:05 ` Zack Weinberg
2016-09-21 18:08 ` Joseph Myers
2016-09-21 18:10 ` Zack Weinberg
2016-09-21 18:46 ` Carlos O'Donell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c9c871d-0c7a-7149-9ec7-7721c927d238@redhat.com \
--to=carlos@redhat.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=zackw@panix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).