From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from fuchsia.ash.relay.mailchannels.net (fuchsia.ash.relay.mailchannels.net [23.83.222.64]) by sourceware.org (Postfix) with ESMTPS id 41F743858D20 for ; Thu, 25 May 2023 00:53:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 41F743858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gotplt.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id AEE1E34114D; Thu, 25 May 2023 00:53:42 +0000 (UTC) Received: from pdx1-sub0-mail-a305.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 3258A341A29; Thu, 25 May 2023 00:53:42 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1684976022; a=rsa-sha256; cv=none; b=s1Gsd1Elspb/zFW4QkNyfscuaxSIZaT6JCz3LdM7MUynZd7rjQtU+hyRh6C9CAm/0WfO/Z IPxhCDtHH2FSO9aU/kq7CkymrVX7VTgHhdfuC1gGjU1T9YdgIZKRHVJbApXGkzCV88+1y+ j9gHlURzsf5fZsh7TV2rO+Rg6uzxZc/QsgAVH8/issNKvGO30rx8GFmjuEYU0N2e79Nnyv ouUsp2KQlQzIIMb00h6m7JLKcUOC+GEwzAYU8QXGv4L2arAlo2WKMoepglmsv1M6rzTQlX 35rNuJWYppdKSQSJ8AN5zbIFfygTTjWsvQsEyvYE4KXKZ9ior/2KKU1b6xDYRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1684976022; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QhB6aYW4HV285MtjJVGCAhusA6TVCm3iGSdjTv+7YKM=; b=ZweacXoGxSHl9PukdMTsBeCWiLg+hgoDhLdbCOliX8gyPD7pAs9RQY14E2HJ4Gdd1meZ6X 7bML7H6wLfoD4+awZx3N5j+5Pgm4ZifMlBM1iGdgZ1IICgJq2GN/I0BlU0SmejPen+juTz 51Ta0jEpUsi8XYbGyfo22hkxpYVYXu/piuT+ENGTQBchWWOPhw7Lg1QhyFsTrqrA9QoOCC epdvcQTDzdwi9SYr9DUgbJN28IK/+1m95xuJP7b+CwdAv5lcsTaB9zQOviL1pI2JPmDznO Weab4XU0L2N5i2Gcsq+t3nx4vLoSNYiJQschV3LOBJvV9EiNOxm6DguS2fWtsA== ARC-Authentication-Results: i=1; rspamd-5cdf8fd7d9-wwc4v; auth=pass smtp.auth=dreamhost smtp.mailfrom=siddhesh@gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Plucky-Drop: 39116a7875036783_1684976022491_1926328326 X-MC-Loop-Signature: 1684976022491:1112911949 X-MC-Ingress-Time: 1684976022490 Received: from pdx1-sub0-mail-a305.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.103.24.74 (trex/6.8.1); Thu, 25 May 2023 00:53:42 +0000 Received: from [192.168.0.182] (bras-vprn-toroon4834w-lp130-02-142-113-138-85.dsl.bell.ca [142.113.138.85]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a305.dreamhost.com (Postfix) with ESMTPSA id 4QRV115mtmzBD; Wed, 24 May 2023 17:53:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gotplt.org; s=dreamhost; t=1684976022; bh=QhB6aYW4HV285MtjJVGCAhusA6TVCm3iGSdjTv+7YKM=; h=Date:Subject:To:From:Content-Type:Content-Transfer-Encoding; b=OyJjw+zM3/gnWVi4dAxEUz309Sl+kuzd2dqg4qqy1g4YPqwi16bD3cIvm8B6eyz6j /nM4Aw9WontTzoNuHqR9mVAltAtxjA9f8sVvlMw4W6vH5ix7uhrWeEMI0Zwk9nedVj LsdjjaMDDfAZ34v0AHrLfHv5AxpFq8kpi9G+58hn8cOcIkUbRIVkc6p7iRQoLKRI/e EyuunRhpr11AGiypVAqUrvKYDELq2wnb56k9EtnjIAjGP0Cx8Xm24p2YYQmrDPdQqe IXqgl9IKUdVNLtTIfU/1MUZMyyBDg497k3jgXdZ/cQoTd0/MKj73zu29OV0GkKTR++ JsSVgqWPbuwJA== Message-ID: <1ca46d9d-6552-7ea5-8ee1-797076dc8707@gotplt.org> Date: Wed, 24 May 2023 20:53:40 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v4 05/15] sunrpc/netname.c: fix warn unused result Content-Language: en-US To: =?UTF-8?B?RnLDqWTDqXJpYyBCw6lyYXQ=?= , libc-alpha@sourceware.org References: <20230428122142.928135-1-fberat@redhat.com> <20230428122142.928135-6-fberat@redhat.com> From: Siddhesh Poyarekar In-Reply-To: <20230428122142.928135-6-fberat@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3037.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-04-28 08:21, Frédéric Bérat wrote: > Fix unused result warnings, detected when _FORTIFY_SOURCE is enabled in > glibc. > --- > sunrpc/netname.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) LGTM. Reviewed-by: Siddhesh Poyarekar > > diff --git a/sunrpc/netname.c b/sunrpc/netname.c > index dd2cb1b441..d9d82501b0 100644 > --- a/sunrpc/netname.c > +++ b/sunrpc/netname.c > @@ -96,7 +96,8 @@ host2netname (char netname[MAXNETNAMELEN + 1], const char *host, > else > { > domainname[0] = 0; > - getdomainname (domainname, MAXHOSTNAMELEN); > + if (getdomainname (domainname, MAXHOSTNAMELEN)) > + return 0; > } > } > else