From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from tiger.tulip.relay.mailchannels.net (tiger.tulip.relay.mailchannels.net [23.83.218.248]) by sourceware.org (Postfix) with ESMTPS id 6AE133858D28 for ; Tue, 27 Jun 2023 11:50:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6AE133858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gotplt.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 6E86814223C; Tue, 27 Jun 2023 11:50:20 +0000 (UTC) Received: from pdx1-sub0-mail-a233.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 00FF2142637; Tue, 27 Jun 2023 11:50:19 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1687866620; a=rsa-sha256; cv=none; b=y/3PvLDLpEcxWf7vl6IIWaNks6s8PvuErLkV0LX4M1H2annBCwKd7zJbRmirHpkJCysFEM qqWiylfJcgtd3JpLxSU7fWghB3dMiPOTFNY0ffegbJoXw88yCZ++RNqcoaZl0QvKqfoBV6 01fiTEwJDznW1QN5wcVjMbaqzoYg4xvTolFhawEoWPXYghPrdDtElNXUlhrtck5pXTKtt2 R3yKE12c+6Ymzz/nSdyk36/RL/Jibm55B3LHdWqAHQwdF/VJqv685qDEUKgayM/dnkWhDP 7xPnN1w+MlBs2UXa9GGsCs5+5kQemz95qlh1pUsoS0gcTj3F68HnMy/LGwbEMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1687866620; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Mnz4trizMql55vao3whxFkUlSG3Evj4txC5UE4R4nbM=; b=LqXBm071w7xVKfFpE8TZZquJey6/zOG80h0rHxWTTGIcuP9p+1XPyW6oRjcd/m3UIpHP5w ELR0ODVgA2Xg338daUgQyFBo6sGcrGr9BOkvzA5uchqC8yMqRV9E4mC/ZiUuX6f/A5vLEL vwrBxdMChTzS/iic1Oqg0vbJaf/iAefGvdlvFi3vsJ5mzPNJEY8D0rm5hkroW9h5bCY3PX YYp4/P0exchzXhGQ5Mi7E/FbhE51u9i6FK/QbEIVIe7Orp3skTh7FfEiwGmvy+mAx+It7h 58Bsd2Uigp6YmFvJVd+xH9vzPcjsWURywAheGMRF1AhOnODu4sCdXeMf2pImKQ== ARC-Authentication-Results: i=1; rspamd-9fcc56855-lxsws; auth=pass smtp.auth=dreamhost smtp.mailfrom=siddhesh@gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Belong-Broad: 3d3c2a7e36dc489e_1687866620236_3319519098 X-MC-Loop-Signature: 1687866620236:1332641560 X-MC-Ingress-Time: 1687866620236 Received: from pdx1-sub0-mail-a233.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.120.163.52 (trex/6.9.1); Tue, 27 Jun 2023 11:50:20 +0000 Received: from [192.168.0.182] (unknown [174.91.45.44]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a233.dreamhost.com (Postfix) with ESMTPSA id 4Qr31R4DfHzHb; Tue, 27 Jun 2023 04:50:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gotplt.org; s=dreamhost; t=1687866619; bh=Mnz4trizMql55vao3whxFkUlSG3Evj4txC5UE4R4nbM=; h=Date:Subject:To:Cc:From:Content-Type:Content-Transfer-Encoding; b=JC6bg4nr9iZ3PXIxhb8eanWzjZpjZNBGEwZAWVSfxDr8bbg+8yXgWU2l5XCFWxXro 7Q9hhvNkpMcgCFwsVhmoCMInB1tNJcUMEsimci+i/XlUnMY4HphaFDV5VYREXWfAwR 7yrG0x9NU+laD4rPSNvSVyYdzjYvfzYk5bvN8Ib7cQPXXwc6OFC3GxkL1n8AkS5CBa jwoKX76o+BikJv3WvnrbboaKa8bcgy+JavzxeZosz7yKkY+c/0Wp9RWlvbpHz2RvVm 4ICB6UC+R9dYJQ/Uhs5M1ffoDkzJDuottcaeqHvxUPXsNPCbKQBeksJF3w2b7N7K0X UfxGHADGLCLWg== Message-ID: <1cc5b4e3-8e96-6ce1-34fc-ae806043a77c@gotplt.org> Date: Tue, 27 Jun 2023 07:50:08 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v6] ifaddrs: Get rid of alloca Content-Language: en-US To: Joe Simmons-Talbott , Adhemerval Zanella Netto Cc: libc-alpha@sourceware.org References: <20230621200053.3021604-1-josimmon@redhat.com> <08935c76-f659-7419-f092-8c700c16a7ed@gotplt.org> <5f42fd62-bf2d-d63f-88c1-85827247e6a1@linaro.org> <20230626210400.GP6392@oak> From: Siddhesh Poyarekar In-Reply-To: <20230626210400.GP6392@oak> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3031.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-06-26 17:04, Joe Simmons-Talbott wrote: > On Mon, Jun 26, 2023 at 04:49:46PM -0300, Adhemerval Zanella Netto wrote: >> >> >> On 26/06/23 10:10, Siddhesh Poyarekar wrote: >>> On 2023-06-22 09:47, Adhemerval Zanella Netto via Libc-alpha wrote: >>>> >>>> >>>> On 21/06/23 17:00, Joe Simmons-Talbott via Libc-alpha wrote: >>>>> Use scratch_buffer and malloc rather than alloca to avoid potential stack >>>>> overflows. >>>> >>>> LGTM, thanks. >>>> >>>> Reviewed-by: Adhemerval Zanella  >>> >>> Adhemerval, would it make sense to have Joe request write access to the repository so that he can push his patches?  Would you sponsor him? >> >> Sure, if he does intend to continue work on glibc I think it should >> be good to allow him to install his own patches. >> > It is my intention to continue working on glibc. Please request commit access for glibc here: https://sourceware.org/cgi-bin/pdw/ps_form.cgi You may mention either Adhemerval or me as the approver. Thanks, Sid