public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Carlos O'Donell <carlos@redhat.com>
To: Sunil Pandey <skpgkp2@gmail.com>,
	Noah Goldstein <goldstein.w.n@gmail.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] x86_64: Align memmove unaligned routines to 64 byte
Date: Mon, 3 Jun 2024 09:29:04 -0400	[thread overview]
Message-ID: <1cd3c23c-e5e7-4e79-aec6-af2896ab1390@redhat.com> (raw)
In-Reply-To: <CAMAf5_ekmidr4ZQ-2VckeH8-3wwWgW=30XjhZnffZ2zX66SXiA@mail.gmail.com>

On 5/29/24 2:53 PM, Sunil Pandey wrote:
> There are people who rely on this benchmark data for their hardware/software
> decision.

They should not, and we should not base our implementation decisions
*solely* on this criteria.

We should take a nuanced approach and think clearly and deeply about
what we want to achieve regarding function performance and any
true alignment requirements.
 
> So, if this implementation is there and we can easily optimize, we should.
> If nothing else, it can reduce their random regression troubleshooting time.

Yes, if it's easy, we can do it... but we should do it only if it really
makes sense for applications.

-- 
Cheers,
Carlos.


      reply	other threads:[~2024-06-03 13:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-29 16:36 Sunil K Pandey
2024-05-29 18:05 ` Noah Goldstein
2024-05-29 18:26   ` Sunil Pandey
2024-05-29 18:33     ` Noah Goldstein
2024-05-29 18:53       ` Sunil Pandey
2024-06-03 13:29         ` Carlos O'Donell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1cd3c23c-e5e7-4e79-aec6-af2896ab1390@redhat.com \
    --to=carlos@redhat.com \
    --cc=goldstein.w.n@gmail.com \
    --cc=libc-alpha@sourceware.org \
    --cc=skpgkp2@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).