From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x2f.google.com (mail-oa1-x2f.google.com [IPv6:2001:4860:4864:20::2f]) by sourceware.org (Postfix) with ESMTPS id C11C73858D38 for ; Mon, 11 Sep 2023 16:17:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C11C73858D38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oa1-x2f.google.com with SMTP id 586e51a60fabf-1c4b4c40281so3039310fac.1 for ; Mon, 11 Sep 2023 09:17:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1694449046; x=1695053846; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=dTwQYXGnwrTrNPR3MakCibfAzVplzHYj53A2UGiEM3Q=; b=nyp8xXQXRzuiykuPqaFV4g0S2R8s3BTJN3WvSlzCDYIseRam7LRWJ5VXLn2YJC8u5v GDur4qEDKmWH3PETHAD5ukJg6WFoPPLIudyqsjI2lRjkAWnMSfsRGbFI31/u5rOx9Zpn am3pFwPTj+1P7RJH1VmzpZEf3766QhUo4mGJ+YGxYujdcqoBsMhi/K7tfC/naQDe9Nnu PtTeavAe65RZ27RbobvaPffRjuvAa2oYrmHW7ArE94H83J3OiI1xUnNCpDqxWT4ftCoX fIbXZnujEaf3Pukc6uG/7xJ1AOip58GfJkYuvvuxv+rf+HqnrtcgTX2VuN2Rh5a+XSAa ScFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694449046; x=1695053846; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dTwQYXGnwrTrNPR3MakCibfAzVplzHYj53A2UGiEM3Q=; b=Lja5zSYG+H+KMu86HjPG+iMji5WUSHU9PC+OHfnr+ZEKWwYD7DxxTDlFbHuGiHSzsM gVacOyf6FiouclXTSZZaMBbhhLCvrXEFdO2qDxrDehZiFc0JroX0GEVbH7nbSK4PnY/O 4n25WdfABw+C2Lw7fE7B3OK8jycm2cWoEJEbcIH94J3JX/aRLV1E6CPzj1yo2wGQD9be 1rV8AvJMxT3NERYb1EqVCiZy4JWSF0Uy212gtr51fwMd3s2U7CPvW3PdPXDCXdkoovsB iJHnjMvL1C59vI6o83ywunAn37HpJsagvAn2J3mt4vpGUYpOA7vTNZmJsmGQwmoxsbDA N7nA== X-Gm-Message-State: AOJu0YyaYw/FEblQeqwF/4sm6iPuS/yQLh17/lvgQGoHmxGpP738U/Nx aIcuXRoa0xmXRYdBPR0JEZpUlA== X-Google-Smtp-Source: AGHT+IGbHEUYxag3lQ9d0cy8cZKqW41BOhHQ09mmoSR+QZ7TM4Myka1MQ0rkzXndW2WWiYu9qh2pFQ== X-Received: by 2002:a05:6870:8e1b:b0:1a9:f6ba:138a with SMTP id lw27-20020a0568708e1b00b001a9f6ba138amr61970oab.0.1694449046156; Mon, 11 Sep 2023 09:17:26 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c0:91cb:1977:7e4f:e638:7fad? ([2804:1b3:a7c0:91cb:1977:7e4f:e638:7fad]) by smtp.gmail.com with ESMTPSA id f3-20020a056870d30300b001c518774ae6sm4124954oag.15.2023.09.11.09.17.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Sep 2023 09:17:25 -0700 (PDT) Message-ID: <1d075708-675d-0ad6-e51c-f911f09ee084@linaro.org> Date: Mon, 11 Sep 2023 13:17:22 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH] RISC-V: Enable static-pie. Content-Language: en-US To: Palmer Dabbelt , yanzhang.wang@intel.com, DJ Delorie , Darius Rad Cc: libc-alpha@sourceware.org References: From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 09/09/23 00:30, Palmer Dabbelt wrote: > On Fri, 08 Sep 2023 20:17:16 PDT (-0700), yanzhang.wang@intel.com wrote: >> I took some time to test the master with binfmt_misc and qemu system mode. >> Both of them can't match the requirements (<= 6 failures). >> >> - most of cases with binfmt_misc fail with abort. > > QEMU user mode isn't a valid test suite target for glibc, there's lots of failures due to the emulation.  I know it's confusing that riscv-gnu-toolchain uses it, that come up when support was added. > >> - most of cases with qemu system fail with timed out. > > You can set TIMEOUTFACTOR, qemu-system is a lot slower than hardware. > >> And also tested with my risc-v board and still fails 70+ cases and most of >> them are math accuracy issue. > > Which board are you running on? > >> So Adhemerval, do you know how to setup the environment to reproduce >> the <= 6 failures ? Maybe I lost some important steps. Thanks very much :). > > +DJ and Darius, who usually report test results.  They've probably got the best idea of how to set things up, but I don't remember this requiring anything fancy. For the specific support of static-pie, I expect that qemu-system or even qemu-user would be a feasible testing platform. You might need some adjustment if the platform implements some math code in assembly, but if you filter out the expected failures it should be doable to check the feature is working as intended. However it is hard to filter out if you just specify the number of failure before/after without breaking down which tests has failed and why (Was is due timeout due emulation? Was it due missing libstdc++.so/libgcc_s.so support? Was is math failure due wrong emulation?). > >> >> Thanks, >> Yanzhang >> >>> -----Original Message----- >>> From: Adhemerval Zanella Netto >>> Sent: Tuesday, August 15, 2023 7:46 PM >>> To: Wang, Yanzhang ; Palmer Dabbelt >>> ; libc-alpha@sourceware.org >>> Subject: Re: [PATCH] RISC-V: Enable static-pie. >>> >>> >>> >>> On 13/08/23 09:20, Wang, Yanzhang via Libc-alpha wrote: >>> > Hi Palmer, >>> > >>> > I have tested the commit(542b110585) with this patch. The results like >>> > below, >>> > >>> > Summary of test results: >>> >     189 FAIL >>> >    4328 PASS >>> >     101 UNSUPPORTED >>> >      16 XFAIL >>> >       2 XPASS >>> > >>> > And the commit(542b110585)'s results like below, >>> > >>> > Summary of test results: >>> >     189 FAIL >>> >    4326 PASS >>> >     101 UNSUPPORTED >>> >      16 XFAIL >>> >       2 XPASS >>> > >>> > The binutils's commit is 2db20b97f1d and gcc's commit is bf36656a14a. >>> > >>> > I use the command make check-glibc-linux in riscv-gnu-toolchain. Not >>> > sure is that acceptable. >>> >>> The riscv reports for 2.38 release [1] list at maximum of 6 FAIL for all >>> the ABI variants.  The 189 failures you are reporting means that your >>> environment is either missing some setup (for instance, copying the >>> libgcc_s.so and libstd++.so on the build folder so C++ and tests that >>> require pthread_cancel or backtrace works correctly) or it is not >>> properly configured. >>> >>> Please sort this out first, since with that amount of failures is not >>> straightforward to check whether static-pie is really working as intended. >>