From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 113110 invoked by alias); 25 Nov 2016 16:14:17 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 113100 invoked by uid 89); 25 Nov 2016 16:14:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=ham version=3.3.2 spammy=*c, *.c, UD:*.c, Hx-languages-length:1827 X-HELO: mail-qk0-f175.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=NcYRGZL9aK+AdhAYRemHWWIkG+gi7ABVPaaRps4BvHk=; b=Pt63bG0mdPL/DhMr8UHDHF6EyF026EP3CTNLaYT7B3c2znPmXIGCN1kW/+YinNZLT5 QhvSbHD4GFtdbjeM1FEyUxm84zOkwAqMtn2Jvw9SWrDojcjttkbLT5UP5W3XKXuTChg/ J2kF+za0f9FVsfJLdUJAG93Vtqb6fnvSeXicNGOws1C81vRuOVCQAb0ZaVhpgEP+G+o1 NurVUCjapiiIxSeZ+e3re6PqSlx8WE8bZD3U6q+vy2KhrrVKE4Ltt9W8fGVJJEUCWboK f/pDepCx+23Modla99siGg2K2ik277yBAd2Er8YU04fDA4n/Op3q3Qq9s4ne4uVeAmUk XYXw== X-Gm-Message-State: AKaTC03VVFVOSzHpUu7WOStK0gBiT1+5fJ0XCe2uXEnLXnXYOVB2M9LIJdiUQ9Q50F5G+g== X-Received: by 10.55.65.23 with SMTP id o23mr7370148qka.186.1480090454009; Fri, 25 Nov 2016 08:14:14 -0800 (PST) Subject: Re: [PATCH] extras: New test/build infrastructure To: libc-alpha@sourceware.org References: <9426ee75-3e45-6cde-b659-567398007a32@redhat.com> From: Zack Weinberg Message-ID: <1d0c74a4-965d-be13-6945-5af479eecbdc@panix.com> Date: Fri, 25 Nov 2016 16:14:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.5.0 MIME-Version: 1.0 In-Reply-To: <9426ee75-3e45-6cde-b659-567398007a32@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2016-11/txt/msg00927.txt.bz2 On 11/25/2016 10:59 AM, Florian Weimer wrote: > I have split up test-skeleton.c into its components. The new test > skeleton should be compatible with compilation in C90 mode. I expect to > use some of these helper functions for future build support on the host > (that is, these routines will have to be compiled twice, once against > the built libc, and once against the host libc). I support this general idea, especially the "not #including test-skeleton.c anymore" part. Can I ask why the new directory is called "extras"? That makes it sound like a home for extra features that we want to provide but not in the core C library. Something more obviously internal-use and build/test-related would be better, I think. (It looks like you've set it up so libextras is not installed, so that's not a concern.) > I do not propose bulk migration at this point. Some obscure use cases > are not supported by the exported hooks. Could you give an example? > +libextras-static-only-routines := $(libextras-routines) > +# Only build one variant of the library. > +libextras-inhibit-o := .os > +ifeq ($(build-shared),yes) > +libextras-inhibit-o += .o > +endif This doesn't look right if the goal is to build only the .a version of the library. > +#ifndef EXTRAS_CHECK_H > +#define EXTRAS_CHECK_H > + > +#include > + > +__BEGIN_DECLS > + > +/* Print failure message to standard output and return 1. */ > +#define FAIL_RET(...) \ > + return __extras_print_failure (__FILE__, __LINE__, __VA_ARGS__) This library is _not_ part of the implementation and should not be using __ names. And I'm not sure it ought to be using features.h either. (I haven't looked over extras/*.c in detail since I assume that these are existing code copied out of test-skeleton.c.) zw