From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x22c.google.com (mail-oi1-x22c.google.com [IPv6:2607:f8b0:4864:20::22c]) by sourceware.org (Postfix) with ESMTPS id 97F753857C78 for ; Wed, 26 Jan 2022 20:08:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 97F753857C78 Received: by mail-oi1-x22c.google.com with SMTP id s127so1811254oig.2 for ; Wed, 26 Jan 2022 12:08:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=xEd3Vrl9e7JA+0DQqYYvIn7msWIX/TjpGHyMMFP9f5U=; b=bOQOwzAYg9ezZRFypFqQpuzC/XeAELhzznTDBj/ADfS9ry5Fz8irq/JiEydJAUaIgv g3nBv2Ml8vCWPZo/G6dbK2RYx5JG63TmudYH+wqB6Gotn7LGyE3siMjf5ki1xK+9ZO40 W1wHCkVGkTh6vt4w/+bRHyu1afRWqk6aqL5+bqJAyeYxNmGKWp6Rr6l8Xc9EWMOdoiRd J3QPB83VW8X0KirB776QsXGZMjhxcV1lj+6Wa3gVJpHaujstHKRVWU3BK/ULCYLIAWHs 2Qf+sXQW9p2iJG1FWQ++EQtliDXfoBZOAxfqBNv0miEuoEBf35BGuPtszecdPlBADvCq C97A== X-Gm-Message-State: AOAM530z4mtyEgYyq+HM1nOoFCQ6pYWS2ULqoZyuxKs/Yi/Pn07GGXQZ 9Q5Kf6oZ0RZRkKSbVAXLj7jMgjV/QAkKwg== X-Google-Smtp-Source: ABdhPJz8xLCDK6+d7l8ecu6PxPLfg9dqqyV03pAyu2PSkKgqL13StLoaInefK2YRsS3SUA84r8EB9Q== X-Received: by 2002:aca:db41:: with SMTP id s62mr169063oig.162.1643227730884; Wed, 26 Jan 2022 12:08:50 -0800 (PST) Received: from ?IPV6:2804:431:c7cb:27f8:9b70:219c:7964:43d? ([2804:431:c7cb:27f8:9b70:219c:7964:43d]) by smtp.gmail.com with ESMTPSA id i23sm4244004otj.19.2022.01.26.12.08.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Jan 2022 12:08:50 -0800 (PST) Message-ID: <1d1c6201-c647-ece0-3c2e-1f6dc31e2ec3@linaro.org> Date: Wed, 26 Jan 2022 17:08:48 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH] Guard tst-valgrind-smoke.out with run-built-tests Content-Language: en-US To: Mark Wielaard , libc-alpha@sourceware.org References: <20220126195737.45163-1-mark@klomp.org> From: Adhemerval Zanella In-Reply-To: <20220126195737.45163-1-mark@klomp.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Jan 2022 20:08:53 -0000 On 26/01/2022 16:57, Mark Wielaard wrote: > Prevent tst-valgrind-smoke from running when run-built-tests is not yes. LGTM, thanks. Reviewed-by: Adhemerval Zanella > --- > elf/Makefile | 2 ++ > 1 file changed, 2 insertions(+) > > Resent as separate PATCH to get it into patchwork. > > diff --git a/elf/Makefile b/elf/Makefile > index daafb5cf12..775c755291 100644 > --- a/elf/Makefile > +++ b/elf/Makefile > @@ -530,7 +530,9 @@ endif > endif > endif > > +ifeq ($(run-built-tests),yes) > tests-special += $(objpfx)tst-valgrind-smoke.out > +endif > $(objpfx)tst-valgrind-smoke.out: tst-valgrind-smoke.sh $(objpfx)ld.so $(objpfx)valgrind-test > $(SHELL) $< $(objpfx)ld.so $(rtlddir)/$(rtld-installed-name) '$(test-wrapper-env)' \ > '$(run-program-env)' '$(rpath-link)' $(objpfx)valgrind-test > $@; $(evaluate-test)