From: Florian Weimer <fweimer@redhat.com>
To: Yury Norov <ynorov@caviumnetworks.com>, libc-alpha@sourceware.org
Cc: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Subject: Re: [PATCH] SYSCALL_CANCEL: reduce the size of generated code
Date: Sat, 15 Apr 2017 07:38:00 -0000 [thread overview]
Message-ID: <1d27a23f-f85b-4fae-d155-17a1b4af82ff@redhat.com> (raw)
In-Reply-To: <1492200452-4653-1-git-send-email-ynorov@caviumnetworks.com>
On 04/14/2017 10:07 PM, Yury Norov wrote:
> SYSCALL_CANCEL() currently calls INLINE_SYSCALL_CALL() both in true and
> false branches of the "if (SINGLE_THREAD_P)" condition. If arguments that
> passed in INLINE_SYSCALL_CALL() are wrapped with tricky macros or require
> other additional handling, the code that does it becomes duplicated, and
> it may increase the size of function that use it significantly.
It also widens the window for the race, so I'm not sure if this is a
good idea.
I think this code will change with the cancellation fixes anyway.
Thanks,
Florian
prev parent reply other threads:[~2017-04-15 7:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-14 20:07 Yury Norov
2017-04-15 7:38 ` Florian Weimer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d27a23f-f85b-4fae-d155-17a1b4af82ff@redhat.com \
--to=fweimer@redhat.com \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
--cc=ynorov@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).