From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4581 invoked by alias); 15 Apr 2017 07:38:04 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 4546 invoked by uid 89); 15 Apr 2017 07:38:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:637, becomes X-HELO: mx1.redhat.com DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com B7B49C05678D Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=fweimer@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com B7B49C05678D Subject: Re: [PATCH] SYSCALL_CANCEL: reduce the size of generated code To: Yury Norov , libc-alpha@sourceware.org Cc: Adhemerval Zanella References: <1492200452-4653-1-git-send-email-ynorov@caviumnetworks.com> From: Florian Weimer Message-ID: <1d27a23f-f85b-4fae-d155-17a1b4af82ff@redhat.com> Date: Sat, 15 Apr 2017 07:38:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 MIME-Version: 1.0 In-Reply-To: <1492200452-4653-1-git-send-email-ynorov@caviumnetworks.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2017-04/txt/msg00266.txt.bz2 On 04/14/2017 10:07 PM, Yury Norov wrote: > SYSCALL_CANCEL() currently calls INLINE_SYSCALL_CALL() both in true and > false branches of the "if (SINGLE_THREAD_P)" condition. If arguments that > passed in INLINE_SYSCALL_CALL() are wrapped with tricky macros or require > other additional handling, the code that does it becomes duplicated, and > it may increase the size of function that use it significantly. It also widens the window for the race, so I'm not sure if this is a good idea. I think this code will change with the cancellation fixes anyway. Thanks, Florian