From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rusty.tulip.relay.mailchannels.net (rusty.tulip.relay.mailchannels.net [23.83.218.252]) by sourceware.org (Postfix) with ESMTPS id 31FE73856959 for ; Mon, 29 Aug 2022 22:08:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 31FE73856959 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gotplt.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id ABC568C085B; Mon, 29 Aug 2022 22:08:43 +0000 (UTC) Received: from pdx1-sub0-mail-a304 (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 408C68C0FEF; Mon, 29 Aug 2022 22:08:43 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1661810923; a=rsa-sha256; cv=none; b=kmZz3aPzPHy28w5g9BFP+NtJ8iavfkUvWlaAp8EvCTVXzciacQH2uBtJaTXMphqTLKq96o Cy/gFDUfKscgKwHbKUZcvEevtTviO0mVRTVMi9h5FWcf05eTKisxsmjiuXA5n/B2CsQXQf ukAUB2KLEuo1/SsNxngyJLy7Eujk52Y6SNy+goen19tB8oiK4Y2XU653EKVUIdZ5bFJrNR w/c6qdPSWoFWDfd55m8+3XRbJz6WhYtL6ZJhrULNqNuNCzXlhsauSF0DNM/Z8+nPjk/IaB mvEJp59tjY9IVV7Fy2q8xWQzFfrGI7hdysMk8PxQHqA6ZGmUbG4npqtMDWLGMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1661810923; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1stJAKK8fG9CiNoxVPkhNmpy9DqMWKloM90Dw6RApDM=; b=iSkZF96tEV2cg8UvPESq14zPa8S+/yFJ/plpUGSx5G9Qe+Sr9omTS75VXXQoVBHzvOwVGR 2bI0AruFT4U1LIk3HKTUkUs+36nYKjdTnGeUjeBQm3undKkiph0v6rRMOgWQ0FSHaz1Qp0 IXa51XS8e+Ye5Dru6/8ShH1tgvZ1LDECvHbKxjL84jgf52/U9ZLPQpddvjx31wIWg1k4IX wRzID/gAuCYmVkhm5z5eZaeP2TSMBLsWpzRt7rb6ODr2ykWtbEuVEOLj4lARLhIawbJ2rm RrA66/Gw95CpYJSeZvzrck8HmvpWCsMP/vavu05CZ3dHHNFpQHPBCUocM1Hvig== ARC-Authentication-Results: i=1; rspamd-75b4464bd-fsbpb; auth=pass smtp.auth=dreamhost smtp.mailfrom=siddhesh@gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Rock-Zesty: 3ea6fb220e566cfc_1661810923498_3112105816 X-MC-Loop-Signature: 1661810923498:2959975969 X-MC-Ingress-Time: 1661810923498 Received: from pdx1-sub0-mail-a304 (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.103.147.32 (trex/6.7.1); Mon, 29 Aug 2022 22:08:43 +0000 Received: from [192.168.0.182] (bras-vprn-toroon4834w-lp130-16-184-147-84-238.dsl.bell.ca [184.147.84.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a304 (Postfix) with ESMTPSA id 4MGl2L4G28zZR; Mon, 29 Aug 2022 15:08:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gotplt.org; s=dreamhost; t=1661810922; bh=1stJAKK8fG9CiNoxVPkhNmpy9DqMWKloM90Dw6RApDM=; h=Date:Subject:To:From:Content-Type:Content-Transfer-Encoding; b=RA24SrI6WlPn6GA7fBY9ys/Yvi9U8GVEws2ciCOAVbqRbZgafbiF/VC+2ATaAikWM HCoFNDyOA15bKSFv5SfQRgY/th3XitxB8RSd3vF92EOWXUVtv7OX/at/1mlBvf/RdS SSGgGnIO9gnamAfy2kSMJcDGQHfx285EB55/vLepttNPaCw3QGVGkHLrbkmKR9KUyR yA0+Xt/DP4V3J7nYLemkhez08rS+c0yeY/uvO1guIdrCvLT1ESqu82kzWar9eev4+8 T6/0xVHC/pf8H2mUmDtW7EYKyWlwlHknW2xlOTfdZI8AHSCVEVlC/QDUz8Mg94Pb/0 5mX3R6Az2GHPg== Message-ID: <1d4f7b43-b306-9521-7fd8-acfce8e70cd3@gotplt.org> Date: Mon, 29 Aug 2022 18:08:41 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH] syslog: Fix large messages (BZ#29536) Content-Language: en-US To: Adhemerval Zanella Netto , libc-alpha@sourceware.org References: <20220829123751.89906-1-adhemerval.zanella@linaro.org> <562fe7a8-a1b1-a355-3250-bb726b33f2bf@gotplt.org> <7cbe02df-a22d-d72f-80c5-62f7676abc22@linaro.org> From: Siddhesh Poyarekar In-Reply-To: <7cbe02df-a22d-d72f-80c5-62f7676abc22@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3032.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2022-08-29 16:19, Adhemerval Zanella Netto wrote: > > > On 29/08/22 17:16, Siddhesh Poyarekar wrote: >> On 2022-08-29 08:37, Adhemerval Zanella via Libc-alpha wrote: >>> The a583b6add407c17cd change did not handle large messages that >>> would require a heap allocation correctly, where the message itself >>> is not take in consideration. >>> >>> This patch fixes it and extend the tst-syslog to check for large >>> messages as well. >>> >>> Checked on x86_64-linux-gnu. >> >> The change itself looks good.  For the test, could it cover both large as well as small strings?  e.g., 64, 1024 and 1280 byte messages. That'll ensure all code paths are covered. > > It already does for small messages that would use the static buffer, do you > think we need to exercise another size (the code path will be identical > to current coverage)? > Ahh sorry I misread the diff. LGTM. Reviewed-by: Siddhesh Poyarekar