From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Andreas Schwab <schwab@suse.de>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] Fix __libc_signal_block_all on sparc64
Date: Mon, 09 Dec 2019 13:19:00 -0000 [thread overview]
Message-ID: <1e01417f-00b1-1658-5d26-d02efd7e658e@linaro.org> (raw)
In-Reply-To: <mvma781acdz.fsf@suse.de>
On 09/12/2019 09:53, Andreas Schwab wrote:
> On Dez 09 2019, Adhemerval Zanella wrote:
>
>> On 09/12/2019 08:59, Andreas Schwab wrote:
>>> On Dez 09 2019, Adhemerval Zanella wrote:
>>>
>>>> On 09/12/2019 08:00, Andreas Schwab wrote:
>>>>> On Dez 05 2019, Adhemerval Zanella wrote:
>>>>>
>>>>>> Where SIGALL_SET is defined as:
>>>>>>
>>>>>> ((__sigset_t) { .__val = {[0 ... _SIGSET_NWORDS-1 ] = -1 } })
>>>>>
>>>>> Why is that not const?
>>>>>
>>>>> Andreas.
>>>>>
>>>>
>>>> It is on the updated version [1].
>>>
>>> Does it help to make it const?
>>>
>>
>> It does, that's the main reason for the updated version
>
> No, I mean without the other changes.
>
The const fixes the issues, the other changes on [1] are essentially
changing __libc_signal_ to return void.
[1] https://sourceware.org/ml/libc-alpha/2019-12/msg00190.html
next prev parent reply other threads:[~2019-12-09 13:19 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-05 14:35 Adhemerval Zanella
2019-12-05 14:46 ` Florian Weimer
2019-12-05 16:52 ` Adhemerval Zanella
2019-12-05 17:05 ` Florian Weimer
2019-12-05 17:13 ` Adhemerval Zanella
2019-12-05 18:34 ` [PATCH v2 1/3] linux: Consolidate sigprocmask Adhemerval Zanella
2019-12-05 18:34 ` [PATCH v2 2/3] linux: Remove SIGCANCEL/SIGSETXID handling on sigprocmask Adhemerval Zanella
2019-12-05 18:34 ` [PATCH v2 3/3] Fix __libc_signal_block_all on sparc64 Adhemerval Zanella
2019-12-05 21:10 ` Adhemerval Zanella
2019-12-09 11:01 ` [PATCH] " Andreas Schwab
2019-12-09 11:27 ` Adhemerval Zanella
2019-12-09 11:59 ` Andreas Schwab
2019-12-09 12:24 ` Adhemerval Zanella
2019-12-09 12:53 ` Andreas Schwab
2019-12-09 13:19 ` Adhemerval Zanella [this message]
2019-12-09 13:23 ` Andreas Schwab
2019-12-09 14:18 ` Adhemerval Zanella
2019-12-09 14:54 ` Andreas Schwab
2019-12-09 16:52 ` Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e01417f-00b1-1658-5d26-d02efd7e658e@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).