From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk1-xa2a.google.com (mail-vk1-xa2a.google.com [IPv6:2607:f8b0:4864:20::a2a]) by sourceware.org (Postfix) with ESMTPS id B1EBC385840F for ; Fri, 12 Nov 2021 19:32:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B1EBC385840F Received: by mail-vk1-xa2a.google.com with SMTP id m19so915742vko.12 for ; Fri, 12 Nov 2021 11:32:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=IlpA3LEUQtoxwySt47sUffUqnbfNBHGQUW7B4Zys/yg=; b=xDR78sRr5x7cfrY9p+pcIHCLwXOOw2s9P3MPzYX8yzP3CnOVy9fpbW7qUnsgNoUB38 PyMZOLffZ6QDB+u7073tX1cKOWZfL/+Zhk3+SXB+yuwxv5qaWkmKJ911wfKmi8eFSE86 6ukItKd0oYEX1xVHSkZvqWHCpQxaFE3vdCCkFQFf/aK40kliGQFH7yx6VHNAwe+cZ/Ur yzuyWuUwyWFUUnA4Tz/KkMps8Zpv+TLQ8TeUG9einuJc92TuVfb4ULbw/Qd2roKl3nbK NW0pCD5NYPBvjefxbGL1OOYTP8s8JdWDIQWEFgLHwn5trYIFlY0Uf/fA493XZavPs7XE uAjA== X-Gm-Message-State: AOAM532a2tS3TblH3OAwMksGTxMIGBVojAZX3Heqi1iGOOmZFiFeD3sL d7BpSoFnmRPOjZEjMIX8R01PVg== X-Google-Smtp-Source: ABdhPJxUQ9fblncvZvB+2TW641qogac1ywnBw7eROMEQlJH3et6WWQ3tBOkzZHyBFSDJ3/UBxocsiQ== X-Received: by 2002:a05:6122:1788:: with SMTP id o8mr26304532vkf.8.1636745539265; Fri, 12 Nov 2021 11:32:19 -0800 (PST) Received: from ?IPV6:2804:431:c7cb:55a:ec9e:6037:1db6:e51? ([2804:431:c7cb:55a:ec9e:6037:1db6:e51]) by smtp.gmail.com with ESMTPSA id f7sm4624205vkm.31.2021.11.12.11.32.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Nov 2021 11:32:19 -0800 (PST) Message-ID: <1e11e17e-4c34-41e8-03ae-8e2be317daf6@linaro.org> Date: Fri, 12 Nov 2021 16:32:17 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [PATCH v5 17/22] elf: Add la_activity during application exit Content-Language: en-US To: Florian Weimer Cc: libc-alpha@sourceware.org, John Mellor-Crummey , Ben Woodard References: <20211109183347.2943786-1-adhemerval.zanella@linaro.org> <20211109183347.2943786-18-adhemerval.zanella@linaro.org> <87r1bmyhyh.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella In-Reply-To: <87r1bmyhyh.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-14.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Nov 2021 19:32:21 -0000 On 11/11/2021 09:50, Florian Weimer wrote: > * Adhemerval Zanella: > >> la_activity() is not called during application exit, even though >> la_objclose is. > > Patch looks okay to me. > > Just a nit: > > >> diff --git a/elf/tst-auditmod23.c b/elf/tst-auditmod23.c >> new file mode 100644 >> index 0000000000..20ef19945d >> --- /dev/null >> +++ b/elf/tst-auditmod23.c > >> + if (map_desc == NULL) >> + abort(); > > Missing space. Ack.