From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x235.google.com (mail-oi1-x235.google.com [IPv6:2607:f8b0:4864:20::235]) by sourceware.org (Postfix) with ESMTPS id 4BCCE385627B for ; Fri, 6 May 2022 13:46:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4BCCE385627B Received: by mail-oi1-x235.google.com with SMTP id m25so7531106oih.2 for ; Fri, 06 May 2022 06:46:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=7NxtbmwQA58Y5seFT3UxmYrOaeU3WQu4aUJ7GYxLw7w=; b=4ZXmhe2bBy8cOHJ9Z58V7jPJdgp13XGSqjQYB2hfk0/dw9oZrVPQLGoPSa1K3F8OY/ VeJ9XffpSuNhRsT6yN4u+jZWLGMvcLbvRFs1l4PcHhfKxUzp/d8jtG3salrjsomT0Ni8 VBE7j87955VJ0A09IjKOudEY+IU4o2BnbqcRBUMUL1A4Ju3678AfJ0oesxTdRdgNx/wW 0wDQJ/eH0oCFny8B9f+cU+ihvHSXlyMCujFJzz8IPzNJ1FFpSh5+XB6rfCLOqBVmINLH d637lOeI99GUf3U1L8ZVADkLUByA5h/q6FT52m0FdTdZ+Ld1/lV4vQcSURWBkAa0OVsY hbig== X-Gm-Message-State: AOAM530lBh2KJgDvI5Y3ochoZu+UtGi+Aiw1gOL3d5fCQTbPDeevaPIw HlHnjLmpsQ+LxybHH8ermMoNNDQ6Ob9JOg== X-Google-Smtp-Source: ABdhPJyDpEnnl5Ct7qT4WMlW1bCteHx48aTbpbp7v8qes7GXk4iDt5XKl9izuI+kQ4I3hd/KJ9bcyg== X-Received: by 2002:a54:469a:0:b0:322:9e32:e71a with SMTP id k26-20020a54469a000000b003229e32e71amr4608666oic.282.1651844791177; Fri, 06 May 2022 06:46:31 -0700 (PDT) Received: from ?IPV6:2804:431:c7cb:726:53f7:4ba7:4810:79df? ([2804:431:c7cb:726:53f7:4ba7:4810:79df]) by smtp.gmail.com with ESMTPSA id n20-20020a056870e41400b000e686d1388esm1523765oag.40.2022.05.06.06.46.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 May 2022 06:46:30 -0700 (PDT) Message-ID: <1e1f591d-1b4c-f356-6c2f-07bd43f18afd@linaro.org> Date: Fri, 6 May 2022 10:46:28 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 1/2] benchtests: Add wcrtomb microbenchmark Content-Language: en-US To: Siddhesh Poyarekar , libc-alpha@sourceware.org References: <20220505184348.3357550-1-siddhesh@sourceware.org> <20220505184348.3357550-2-siddhesh@sourceware.org> <90b8a390-c7d4-39d8-569e-caf104e7bd50@linaro.org> <3b242ccc-3e29-ebb5-9966-fa02f91ca49c@gotplt.org> <5be78a3d-3003-420e-0b8b-dcccbefaeebf@gotplt.org> From: Adhemerval Zanella In-Reply-To: <5be78a3d-3003-420e-0b8b-dcccbefaeebf@gotplt.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 May 2022 13:46:35 -0000 On 06/05/2022 10:36, Siddhesh Poyarekar wrote: > On 06/05/2022 18:56, Siddhesh Poyarekar wrote: >> On 06/05/2022 18:50, Adhemerval Zanella wrote: >>> >>> >>> On 06/05/2022 09:59, Siddhesh Poyarekar wrote: >>>> (Sorry I just committed it before I saw your message) >>>> >>>> On 06/05/2022 18:20, Adhemerval Zanella via Libc-alpha wrote: >>>>>> +  /* 4-byte chars, because smileys are the universal language and we want to >>>>>> +     ensure optimal performance with them 😊.  */ >>>>>> +  {"en_US.UTF-8", >>>>>> +   L"😀😁😂😃😄😅😆😇😈😉😊😋😌😍😎😏😐😑😒😓😔😕😖😗😘😙😚😛😜😝😞😟😠😡"} >>>>>> +}; >>>>> >>>>> Could you use use hexadecimal character escape in tests? Although gcc handle multiple >>>>> -fexec-charset, trying to build it with a different compiler usually emits a lot of >>>>> warnings. >>>>> >>>> >>>> Hmm, I'm curious to know which compiler this breaks on; it's straight up UTF-8 so should parse just fine, no? >>> >>> I does not really breaks, but clang warns about character enconding (I forgot >>> which was the specific error, I will check it). I have to fix a lot of internal >>> usage to get a clean make check on clang [1]. >>> >>> [1] https://sourceware.org/git/?p=glibc.git;a=commit;h=058bb0d51c3f85041c7cbd14704f72003bdbdee9 >>> >> >> Ah, so that's all ISO-8859, it shouldn't warn on utf-8. > > In any case, if you see warnings on this, please pass it on to me and I'll fix it but it seems wrong for clang to warn on this. Yeah, the issue is ISO-8859 in fact. The L'...' with UTF-8 does not trigger any issue.