From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x230.google.com (mail-oi1-x230.google.com [IPv6:2607:f8b0:4864:20::230]) by sourceware.org (Postfix) with ESMTPS id E69773858D35 for ; Thu, 3 Nov 2022 21:28:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E69773858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oi1-x230.google.com with SMTP id s206so3407983oie.3 for ; Thu, 03 Nov 2022 14:28:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=uzQqVdkVs9CNeCroyMYPI7D9eHGkiY100eWMV9SLMgU=; b=exR8SUY6bzK+dg5xPXVzOFg7aLFlv4AE95dit7zxZX90fnceVDBnoIq0moa5LKl1fR Ot0WWO6DY3QT6PQhQK91+vuszdePRqsHD0G58PFdclA8znpkvtIVVuLO13bmwp6XgpGJ zr5AQy0tE17vqPL2rC89xHjQfstIZ11TD6wwz7W+0Xzw9xgo4L0AlteWAOoXX9aAS8K6 NnSah5JaaXGyIIo/Lp2uRgEZqQ5ku+AmnVxdgqK1h/YRCICcO0fQ/BOCZi/LgnNbR1y+ Xco9YqlLiLTcfJKxHIUAa5Pv1DMaq4jlPfd6QJeZNWWiHSkNo+mDC0ipKpDu+COB+/oW K+Og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=uzQqVdkVs9CNeCroyMYPI7D9eHGkiY100eWMV9SLMgU=; b=qzKccQZDIenofVOkENm+AABGRFKhKGbeNSalz7wMpE4PiotLM8mAIGbCJ2Q9wYp/uo F71wcThcxeA/W+9DClGAm3dTCSsBcEUwuRj8s2GUyk4SC+SH+2KfH3KZFi3GZ0vO2mlb GpzhLgCO0gYaJOWPDe49BcLwvn4KSO3bkdT86NkXA+ADGSiG9e8pDpaw3SZJ1p0Q6pJg 2tvOE/j7c+qFgc7fALmqQNiASsOos+sWwaR8rA/EAKiaVOA8EvwtYCZA4lqSxmXaG7/W tecdwGFv7yKfe5oEttsdvacXtlah4uq2/QWVMa8IQfSSPosGvloB2dnujNbcQE4J2FEj i+TA== X-Gm-Message-State: ACrzQf2JT3mR3s/QlZeC64EhWQztgzc65XSxbbV6xIkSdli3tIAB3Wom lvS2TFAefjY4gHUCnb2wIwpfSw== X-Google-Smtp-Source: AMsMyM6xw5Ugncqatbrnu2aSKXaiiEUtfWGwatQd1Kk5hf6R8wZVsIq8Z81ZKzSoGdl2CY0+wb5+sQ== X-Received: by 2002:a05:6808:8e3:b0:35a:13a7:2abf with SMTP id d3-20020a05680808e300b0035a13a72abfmr11785833oic.256.1667510913140; Thu, 03 Nov 2022 14:28:33 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c0:a9f4:4405:8c19:a65e:e640? ([2804:1b3:a7c0:a9f4:4405:8c19:a65e:e640]) by smtp.gmail.com with ESMTPSA id l24-20020a05683004b800b00661948e6119sm789387otd.47.2022.11.03.14.28.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Nov 2022 14:28:32 -0700 (PDT) Message-ID: <1ed259d8-9ae8-7e6b-9eed-8d5b8e3ef3a5@linaro.org> Date: Thu, 3 Nov 2022 18:28:29 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH v2 4/9] aarch64: Add the clone3 wrapper Content-Language: en-US To: "H.J. Lu" Cc: Szabolcs Nagy , libc-alpha@sourceware.org, Christian Brauner References: <20220930192613.3491147-1-adhemerval.zanella@linaro.org> <20220930192613.3491147-5-adhemerval.zanella@linaro.org> <1d4ce210-2b28-b061-9780-f643eaa80a27@linaro.org> <8a3dc5d9-b731-4c45-7252-8157ba0be6c2@linaro.org> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 03/11/22 17:55, H.J. Lu wrote: > On Thu, Nov 3, 2022 at 9:55 AM Adhemerval Zanella Netto > wrote: >> >> >> >> On 03/11/22 13:52, Szabolcs Nagy wrote: >>> The 11/03/2022 13:39, Adhemerval Zanella Netto wrote: >>>> >>>> >>>> On 03/11/22 13:31, Szabolcs Nagy wrote: >>>>> The 11/03/2022 13:22, Adhemerval Zanella Netto wrote: >>>>>> >>>>>> >>>>>> On 03/11/22 11:01, Szabolcs Nagy wrote: >>>>>>> The 11/03/2022 10:15, Adhemerval Zanella Netto wrote: >>>>>>>> On 02/11/22 09:12, Szabolcs Nagy wrote: >>>>>>>>> The 09/30/2022 16:26, Adhemerval Zanella via Libc-alpha wrote: >>>>>>>>>> It follow the internal signature: >>>>>>>>>> >>>>>>>>>> extern int clone3 (struct clone_args *__cl_args, size_t __size, >>>>>>>>>> int (*__func) (void *__arg), void *__arg); >>>>>>>>>> >>>>>>>>>> And x86_64 semantics to return EINVAL if either cl_args or func >>>>>>>>>> is NULL. The stack is 16-byte aligned prior executing func. >>>>>>>>> >>>>>>>>> "x86_64 semantics" sounds wrong: maybe this should be documented? >>>>>>>>> i'd expect 0 cl_args/func to be UB like in most posix apis. >>>>>>>> >>>>>>>> Right, I think it is worth to document the function semantic >>>>>>>> properly at least on its internal header (include/clone_internal.h). >>>>>>>> H.J also added a new clone3.h headers, which is not currently installed >>>>>>>> that I am inclined to just remove it from now. We might reinstate >>>>>>>> if/when we decide to provide the clone3 as an ABI. >>>>>>>> >>>>>>>> And returning EINVAL for 0 cl_args/func aligns with our exported clone >>>>>>>> interface, where EINVAL is also returned for 0 function argument. >>>>>>> >>>>>>> ok. >>>>>>> >>>>>>>>> >>>>>>>>> and aligning sp in the child fails if signals are allowed there >>>>>>>>> (pthreads does not allow signals now, direct callers might). >>>>>>>>> i dont know if that's a concert (or if unaligned stack is >>>>>>>>> something we should fix up in clone3). >>>>>>>> >>>>>>>> It was overlooked on initial x86_64 clone3 implementation as well. I >>>>>>>> think it better to just return EINVAL for unaligned stacks and avoid >>>>>>>> to change the stack pointer in the created thread. >>>>>>> >>>>>>> long time ago linux did that on aarch64, but it was removed: >>>>>>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e6d9a52543338603e25e71e0e4942f05dae0dd8a >>>>>>> >>>>>>> i think in clone3 the kernel should have aligned (it knows >>>>>>> the bounds now), doing it in the userspace wrapper is weird >>>>>>> (should we adjust the stack size?). and not doing it at all >>>>>>> makes clone3 hard to use portably (user has to know target >>>>>>> specific pcs requirements). >>>>>>> >>>>>>> not sure what's the best way forward. >>>>>> >>>>>> I think the stack size won't matter much here, at least not from >>>>>> kernel point of view (the resulting stack size will most likely >>>>>> be page aligned anyway). But I think this kernel commit makes a good >>>>>> point that silently adjusting the stack in userland is not the >>>>>> correct approach, I think H.J has done to make it consistent with >>>>>> glibc clone implementation which does it. >>>>>> >>>>>> IMHO the best approach would to just remove the stack alignment, >>>>>> since it incurs the signal handling issue. >>>>> >>>>> current generic clone callers dont align the stack and >>>>> e.g. unaligned pthread custom stack should work. >>>>> >>>>> so we have to do arch specific stack alignment somewhere, >>>>> maybe in pthread_create? >>>> >>>> I am thinking on __clone_internal, where if an unaligned stack is >>>> used it creates a new clone_args struct with adjust arguments. It >>>> can adjust the struct in place (not sure which is better). >>> >>> if the api is not exposed, then i think the arg can be modified >>> in place. (if clone3 api is exposed to users then we should not >>> modify user structs unless the clone3 api contract explicitly >>> allows this.) >>> >>> either aligning in pthread_create or __clone_internal works for me, >>> the target specific clone3 syscall should not in case that gets >>> exposed to users. >>> >> >> The arg modification would be done only internally by __clone_internal, >> if we ever export __clone3 it will not mess with stack alignment (my >> idea is to remove it from x86_64 as well). > > Is there a bug for the signal handling issue? No with current usage, on both pthread_create and posix_spawn glibc mask all internal signals (including internal ones).