Re: [PATCH v3 3/4] linux: Normalize and return timeout on select (BZ #27651)

[Adhemerval Zanella <adhemerval.zanella@linaro.org>]

On 12/04/2021 09:20, Adhemerval Zanella wrote:
> 
> 
> On 12/04/2021 05:28, Andreas Schwab wrote:
>> On Apr 09 2021, Adhemerval Zanella via Libc-alpha wrote:
>>
>>> @@ -52,10 +74,13 @@ __select64 (int nfds, fd_set *readfds, fd_set *writefds, fd_set *exceptfds,
>>>           (though the pselect() glibc call suppresses this behavior).
>>>           Since select() on Linux has the same behavior as the pselect6
>>>           syscall, we update the timeout here.  */
>>> -      if (r == 0 || errno != ENOSYS)
>>> +      if (r >= 0 || errno != ENOSYS)
>>>  	{
>>>  	  if (timeout != NULL)
>>> -	    TIMEVAL_TO_TIMESPEC (timeout, &ts64);
>>> +	    {
>>> +	      timeout->tv_sec = ts64.tv_sec;
>>> +	      timeout->tv_usec = ts64.tv_nsec / NSEC_PER_USEC;
>>> +	    }
>>
>> What's wrong with TIMESPEC_TO_TIMEVAL?
>>
>> Andreas.
>>
> 
> None in fact, I will adjust to use TIMESPEC_TO_TIMEVAL.
> 

Are you ok with the patch with the TIMESPEC_TO_TIMEVAL change?