From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 90628 invoked by alias); 11 Jul 2018 16:24:47 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 90514 invoked by uid 89); 11 Jul 2018 16:24:33 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1620 X-HELO: mail-vk0-f66.google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=RPxfQjHPEBI27pFh4esd4oqvf93PgTHCLFHAHk9XOiU=; b=VMw2XhoCvcnpcCKbp/A5zgLZY62pOihZS9bVptY4vrGQtaxSWsTcF8VIDJax4xfZ1g tcvt5lunU438sh26pRIgANDlTIPp/QKxYpTush+j4DHxbCuf9kpKz7UFVDtxjZAeemdD 3c4EFKvK9j12ZR9gmx1Hk7ePONholDuCifF6s= Return-Path: Subject: Re: [PATCH v8 1/8] nptl: Add C11 threads thrd_* functions To: Szabolcs Nagy , Florian Weimer , libc-alpha@sourceware.org Cc: nd@arm.com References: <1517591084-11347-1-git-send-email-adhemerval.zanella@linaro.org> <1517591084-11347-2-git-send-email-adhemerval.zanella@linaro.org> <23dd1909-5ec2-34b7-9672-827251a4be65@redhat.com> <176c958e-45d6-c1fc-49e4-4eca813d460f@linaro.org> <0566f5a5-f56c-7dd9-5ba6-91c67d9633e9@arm.com> From: Adhemerval Zanella Openpgp: preference=signencrypt Message-ID: <1fdcdd41-5160-f6db-e585-9775e5b581c3@linaro.org> Date: Wed, 11 Jul 2018 16:24:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <0566f5a5-f56c-7dd9-5ba6-91c67d9633e9@arm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2018-07/txt/msg00290.txt.bz2 On 11/07/2018 12:49, Szabolcs Nagy wrote: > On 10/07/18 20:26, Adhemerval Zanella wrote: >> >> >> On 06/07/2018 09:46, Florian Weimer wrote: >>> On 02/02/2018 06:04 PM, Adhemerval Zanella wrote: >>>> @@ -139,7 +139,9 @@ libpthread-routines = nptl-init vars events version pt-interp \ >>>>                  pthread_mutex_getprioceiling \ >>>>                  pthread_mutex_setprioceiling \ >>>>                  pthread_setname pthread_getname \ >>>> -              pthread_setattr_default_np pthread_getattr_default_np >>>> +              pthread_setattr_default_np pthread_getattr_default_np \ >>>> +              thrd_create thrd_current thrd_detach thrd_equal \ >>> >>> thrd_current should live in libc, not in libpthread.  Same for thrd_equal, I suppose.  You should just duplicate the comparison, seeing that we haven't done that particular cleanup for pthread_equal yet. >>> >>> Not sure about thrd_sleep and thrd_yield, but I lean towards libc there as well. >> >> Right, I added all four symbols (thrd_current, thrd_equal, thrd_sleep, and >> thrd_yield) to libc on my personal branch [1] (the change is just to move >> the objects from libpthread-routines to routines rule in nptl/Makefile). >> I also adjusted the abilist patch with the change. >> > > the abilist patch seems to add > sysdeps/unix/sysv/linux/tile/tilegx64/libpthread.abilist > i think you can drop that (and update the ChangeLog). Thanks for catching this up, I fixed on my personal c11 thread branch.