From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-97949-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 33399 invoked by alias); 4 Dec 2018 19:50:59 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 33377 invoked by uid 89); 4 Dec 2018 19:50:58 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=
X-HELO: mail.efficios.com
DKIM-Filter: OpenDKIM Filter v2.10.3 mail.efficios.com DCC5A9EDAB
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com;
	s=default; t=1543953054;
	bh=+zVGABJb4waJEo0jE0aHRjh6BYIKymGmDY6lWxHg7fA=;
	h=Date:From:To:Message-ID:MIME-Version;
	b=RLNOhbw/ZbfHsnwKT8Whsk+HTRQiz0d9XHbQjOMXXt7Xp2q3N+Y5Nltyy6aMYBdyv
	 VwkvqQ2qaQofzfYy6/dv4aX+AU6tv7Uvx5rdwbjnTXUUu35acNSSiHi8kJ0T0/OyT7
	 6Dh7qXy2BsOJWOJsL0QdqFbgkfns/XbT/U67vZLAFa159ZVxOjPh44doZmtdsCLoiO
	 yDO6ZjEanbAzyqc/qQl4HHyeHdhNDUiZoziijC5xToS5ElgGa/JY3/CUmIDOCCGuUS
	 NjJH97Se5hEcefSTujhPkcgz84vRRUkUAbLUQwo93nQyZI9lOIjINGfQR54uIEPHfW
	 Fjjv+pLoO/fMg==
Date: Tue, 04 Dec 2018 19:50:00 -0000
From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To: Florian Weimer <fweimer@redhat.com>
Cc: carlos <carlos@redhat.com>, Joseph Myers <joseph@codesourcery.com>, 
	Szabolcs Nagy <szabolcs.nagy@arm.com>, 
	libc-alpha <libc-alpha@sourceware.org>, 
	Thomas Gleixner <tglx@linutronix.de>, Ben Maurer <bmaurer@fb.com>, 
	Peter Zijlstra <peterz@infradead.org>, 
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>, 
	Boqun Feng <boqun.feng@gmail.com>, Will Deacon <will.deacon@arm.com>, 
	Dave Watson <davejwatson@fb.com>, Paul Turner <pjt@google.com>, 
	Rich Felker <dalias@libc.org>, 
	linux-kernel <linux-kernel@vger.kernel.org>, 
	linux-api <linux-api@vger.kernel.org>
Message-ID: <2002498237.18908.1543953054629.JavaMail.zimbra@efficios.com>
In-Reply-To: <8736rd13i7.fsf@oldenburg2.str.redhat.com>
References: <20181204192141.4684-1-mathieu.desnoyers@efficios.com> <8736rd13i7.fsf@oldenburg2.str.redhat.com>
Subject: Re: [RFC PATCH glibc 1/4] glibc: Perform rseq(2) registration at
 nptl init and thread creation (v4)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2018-12/txt/msg00114.txt.bz2

----- On Dec 4, 2018, at 2:44 PM, Florian Weimer fweimer@redhat.com wrote:

> * Mathieu Desnoyers:
> 
>> diff --git a/sysdeps/unix/sysv/linux/riscv/rv64/libpthread.abilist
>> b/sysdeps/unix/sysv/linux/riscv/rv64/libpthread.abilist
>> index c370fda73d..9da78d59d2 100644
>> --- a/sysdeps/unix/sysv/linux/riscv/rv64/libpthread.abilist
>> +++ b/sysdeps/unix/sysv/linux/riscv/rv64/libpthread.abilist
>> @@ -235,3 +235,4 @@ GLIBC_2.28 tss_create F
>>  GLIBC_2.28 tss_delete F
>>  GLIBC_2.28 tss_get F
>>  GLIBC_2.28 tss_set F
>> +GLIBC_2.29 __rseq_refcount T 0x4
> 
> This part looks buggy.
> 
> It's unclear based on this patch whether you actually want to get rid of
> the __rseq_refcount symbol.

I want to keep the __rseq_refcount symbol so out-of-libc users can
register rseq if they are linked against a pre-2.29 libc.

Why does it look buggy ?

Thanks,

Mathieu


-- 
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com