From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23399 invoked by alias); 12 Sep 2014 18:06:58 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 23378 invoked by uid 89); 12 Sep 2014 18:06:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00 autolearn=no version=3.3.2 X-HELO: topped-with-meat.com MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit From: Roland McGrath To: Siddhesh Poyarekar Cc: libc-alpha@sourceware.org Subject: Re: [PATCH 2/2] Add correct variable names for _POSIX_IPV6 and _POSIX_RAW_SOCKETS In-Reply-To: Siddhesh Poyarekar's message of Friday, 12 September 2014 16:43:16 +0530 <20140912111316.GA28404@spoyarek.pnq.redhat.com> References: <20140912111316.GA28404@spoyarek.pnq.redhat.com> Message-Id: <20140912180655.B67FB2C3981@topped-with-meat.com> Date: Fri, 12 Sep 2014 18:06:00 -0000 X-CMAE-Score: 0 X-CMAE-Analysis: v=2.1 cv=SvUDtp+0 c=1 sm=1 tr=0 a=WkljmVdYkabdwxfqvArNOQ==:117 a=14OXPxybAAAA:8 a=P8mQSCRoW5QA:10 a=17EzXLcla2UA:10 a=Z6MIti7PxpgA:10 a=kj9zAlcOel0A:10 a=hOe2yjtxAAAA:8 a=kxFKtbHUXgfUM4RxDfMA:9 a=CjuIK1q_8ugA:10 a=SCPTnc8OnHkA:10 a=BD1aMvdlIRMA:10 a=6_6lJofy7wUA:10 X-SW-Source: 2014-09/txt/msg00292.txt.bz2 That looks OK. But we should consider as a cleanup removing all the #ifdef's from getconf.c entirely. All configurations use the same bits/confname.h, so there is no actual variation being tested here. I'm not sure that POSIX actually allows us any leeway to omit any of the _SC_* or _PC_* symbols. But even if it does, I can't really see a reason why we'd want to let the GNU API vary that way.