From: Mike Frysinger <vapier@gentoo.org>
To: Vincent Bernat <Vincent.Bernat@exoscale.ch>
Cc: libc-alpha@sourceware.org, Vincent Bernat <vincent@bernat.im>
Subject: Re: [PATCH] time: in strptime(), make %z accept Z as a time zone
Date: Fri, 06 Mar 2015 10:11:00 -0000 [thread overview]
Message-ID: <20150306101121.GU12857@vapier> (raw)
In-Reply-To: <1422371140-27932-1-git-send-email-Vincent.Bernat@exoscale.ch>
[-- Attachment #1: Type: text/plain, Size: 735 bytes --]
On 27 Jan 2015 16:05, Vincent Bernat wrote:
> In ISO 8601, the timezone can be 'Z' instead of using
> digits. 2014-08-17T12:33:12+0000 is often expressed as
> 2014-08-17T12:33:12Z.
code wise, this looks good to me. style problems though ...
> --- a/time/strptime_l.c
> +++ b/time/strptime_l.c
>
> - also specified. */
> + also specified. 'Z' is equivalent to +0000. */
GNU style puts two spaces after the period
> {
> val = 0;
> while (ISSPACE (*rp))
> ++rp;
> + if (*rp == 'Z')
> + {
> + rp++;
> + break;
> + }
indentation is incorrect -- you need to start with a tab
minor nit: this code would do ++rp instead of rp++
-mike
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-03-06 10:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-27 15:20 [PATCH] time: ensure failing strptime() tests are reported correctly Vincent Bernat
2015-01-27 16:02 ` [PATCH] time: in strptime(), make %z accept Z as a time zone Vincent Bernat
2015-03-06 10:11 ` Mike Frysinger [this message]
2015-01-27 16:03 ` [PATCH] time: in strptime(), make %z accept [+-]HH:MM time zones Vincent Bernat
2015-03-06 10:21 ` Mike Frysinger
2015-03-06 11:06 ` Vincent Bernat
2015-04-20 11:42 ` [BZ #17887][PATCH] " Vincent Bernat
2015-03-06 10:04 ` [PATCH] time: ensure failing strptime() tests are reported correctly Mike Frysinger
2015-03-06 11:02 ` Vincent Bernat
2015-03-06 11:07 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150306101121.GU12857@vapier \
--to=vapier@gentoo.org \
--cc=Vincent.Bernat@exoscale.ch \
--cc=libc-alpha@sourceware.org \
--cc=vincent@bernat.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).