From: Roland McGrath <roland@hack.frob.com>
To: Torvald Riegel <triegel@redhat.com>
Cc: GLIBC Devel <libc-alpha@sourceware.org>,
David Miller <davem@davemloft.net>
Subject: Re: [PATCH v5] Add and use new glibc-internal futex API.
Date: Thu, 09 Jul 2015 21:34:00 -0000 [thread overview]
Message-ID: <20150709213433.0F0B42C39DC@topped-with-meat.com> (raw)
In-Reply-To: Torvald Riegel's message of Friday, 3 July 2015 21:04:01 +0200 <1435950241.10077.70.camel@localhost.localdomain>
> This works so far:
> grep -r futex_ | grep '((unsigned int'
OK.
> I believe we can commit this early next week, so you can get your
> testing done. I also want to give David some time to test on sparc too.
NaCl testing is all happy.
> > It wouldn't hurt to write up somewhere, probably on the wiki (though in
> > code comments in this patch would also be fine by me) the known/intended
> > further steps of transition and cleanup in this area.
>
> I added a few notes here: https://sourceware.org/glibc/wiki/Concurrency
Good.
> I've removed the changes to nptl/cancellation.c from this patch because
> I was running into build failures on i686-linux, which happen when calls
> to __libc_fatal() or abort() exist in the code. This seems to happen
> when IS_IN (libc) is true. I don't know why that happens but it seems
> orthogonal to the futex API. Therefore, to move forward with the futex
> API, I choose to simply drop the respective changes from the patch.
>
> Roland, do you have any suggestion how this could be fixed? (You argued
> for calling __libc_fatal there ;) Or anyone else?
I'll look into it.
Thanks,
Roland
next prev parent reply other threads:[~2015-07-09 21:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-22 19:55 [PATCH v3] " Torvald Riegel
2015-06-25 10:15 ` Roland McGrath
2015-07-01 11:20 ` [PATCH v4] " Torvald Riegel
2015-07-01 14:10 ` Torvald Riegel
2015-07-01 14:24 ` Andreas Schwab
2015-07-01 16:39 ` Torvald Riegel
2015-07-01 18:04 ` Andreas Schwab
2015-07-02 1:27 ` Roland McGrath
2015-07-03 19:04 ` [PATCH v5] " Torvald Riegel
2015-07-09 21:34 ` Roland McGrath [this message]
2015-07-09 22:45 ` Roland McGrath
2015-07-10 16:41 ` Torvald Riegel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150709213433.0F0B42C39DC@topped-with-meat.com \
--to=roland@hack.frob.com \
--cc=davem@davemloft.net \
--cc=libc-alpha@sourceware.org \
--cc=triegel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).