* [COMMITTED PATCH] Remove unnecessary mutex locks from tst-tls-atexit test case
@ 2015-07-10 17:59 Siddhesh Poyarekar
0 siblings, 0 replies; only message in thread
From: Siddhesh Poyarekar @ 2015-07-10 17:59 UTC (permalink / raw)
To: libc-alpha
The locks don't synchronize with anything - they were likely
introduced initially to synchronize with some main thread code, but
that is no longer evident.
Committed as obvious.
Siddhesh
---
ChangeLog | 3 +++
stdlib/tst-tls-atexit.c | 3 ---
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 8ee61d6..0c7fc2c 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,8 @@
2015-07-10 Siddhesh Poyarekar <siddhesh@redhat.com>
+ * stdlib/tst-tls-atexit.c (load): Remove unnecessary mutex
+ locks.
+
* stdlib/tst-tls-atexit.c (load): Avoid boolean coercion.
2015-07-10 Torvald Riegel <triegel@redhat.com>
diff --git a/stdlib/tst-tls-atexit.c b/stdlib/tst-tls-atexit.c
index 7a69722..5ee04a8 100644
--- a/stdlib/tst-tls-atexit.c
+++ b/stdlib/tst-tls-atexit.c
@@ -29,12 +29,10 @@
#include <errno.h>
void *handle;
-pthread_mutex_t m = PTHREAD_MUTEX_INITIALIZER;
void *
load (void *u)
{
- pthread_mutex_lock (&m);
handle = dlopen ("$ORIGIN/tst-tls-atexit-lib.so", RTLD_LAZY);
if (handle == NULL)
{
@@ -55,7 +53,6 @@ load (void *u)
/* This should not unload the DSO. If it does, then the thread exit will
result in a segfault. */
dlclose (handle);
- pthread_mutex_unlock (&m);
return NULL;
}
--
2.4.3
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2015-07-10 17:59 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-07-10 17:59 [COMMITTED PATCH] Remove unnecessary mutex locks from tst-tls-atexit test case Siddhesh Poyarekar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).