* [COMMITTED PATCH] Fix c++-types-check conditionalization.
@ 2016-03-04 21:25 Roland McGrath
2016-03-07 20:58 ` Tulio Magno Quites Machado Filho
2016-03-08 17:25 ` Carlos O'Donell
0 siblings, 2 replies; 4+ messages in thread
From: Roland McGrath @ 2016-03-04 21:25 UTC (permalink / raw)
To: GNU C. Library; +Cc: Tulio Magno Quites Machado Filho
Committed as obvious.
I noticed this because the power8-linux build slave hit it (and another
patch to follow). It's nice that we fix all the gratuitous failures when
no C++ compiler is available. But we do want the bots to have C++
compilers available, so the power8 bot should get whatever it's missing
installed.
Thanks,
Roland
2016-03-04 Roland McGrath <roland@hack.frob.com>
* Makefile ($(objpfx)c++-types-check.out): Fix conditionalization
to test for empty $(CXX) rather than $(CXX) of "no".
diff --git a/Makefile b/Makefile
index 7fc92ae..9c6918d 100644
--- a/Makefile
+++ b/Makefile
@@ -252,8 +252,8 @@ tests-clean:
@$(MAKE) subdir_testclean no_deps=t
tests-special += $(objpfx)c++-types-check.out $(objpfx)check-local-headers.out
-ifneq ($(CXX),no)
+ifneq (,$(CXX))
vpath c++-types.data $(+sysdep_dirs)
$(objpfx)c++-types-check.out: c++-types.data scripts/check-c++-types.sh
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [COMMITTED PATCH] Fix c++-types-check conditionalization.
2016-03-04 21:25 [COMMITTED PATCH] Fix c++-types-check conditionalization Roland McGrath
@ 2016-03-07 20:58 ` Tulio Magno Quites Machado Filho
2016-03-08 17:25 ` Carlos O'Donell
1 sibling, 0 replies; 4+ messages in thread
From: Tulio Magno Quites Machado Filho @ 2016-03-07 20:58 UTC (permalink / raw)
To: Roland McGrath; +Cc: GNU C. Library
Roland McGrath <roland@hack.frob.com> writes:
> Committed as obvious.
>
> I noticed this because the power8-linux build slave hit it (and another
> patch to follow). It's nice that we fix all the gratuitous failures when
> no C++ compiler is available. But we do want the bots to have C++
> compilers available, so the power8 bot should get whatever it's missing
> installed.
It was missing glibc-static and it should be fixed now.
Thanks!
--
Tulio Magno
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [COMMITTED PATCH] Fix c++-types-check conditionalization.
2016-03-04 21:25 [COMMITTED PATCH] Fix c++-types-check conditionalization Roland McGrath
2016-03-07 20:58 ` Tulio Magno Quites Machado Filho
@ 2016-03-08 17:25 ` Carlos O'Donell
2016-03-08 20:37 ` Roland McGrath
1 sibling, 1 reply; 4+ messages in thread
From: Carlos O'Donell @ 2016-03-08 17:25 UTC (permalink / raw)
To: Roland McGrath, GNU C. Library; +Cc: Tulio Magno Quites Machado Filho
On 03/04/2016 04:25 PM, Roland McGrath wrote:
> Committed as obvious.
>
> I noticed this because the power8-linux build slave hit it (and another
> patch to follow). It's nice that we fix all the gratuitous failures when
> no C++ compiler is available. But we do want the bots to have C++
> compilers available, so the power8 bot should get whatever it's missing
> installed.
>
>
> Thanks,
> Roland
>
>
> 2016-03-04 Roland McGrath <roland@hack.frob.com>
>
> * Makefile ($(objpfx)c++-types-check.out): Fix conditionalization
> to test for empty $(CXX) rather than $(CXX) of "no".
>
> diff --git a/Makefile b/Makefile
> index 7fc92ae..9c6918d 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -252,8 +252,8 @@ tests-clean:
> @$(MAKE) subdir_testclean no_deps=t
>
> tests-special += $(objpfx)c++-types-check.out $(objpfx)check-local-headers.out
> -ifneq ($(CXX),no)
>
> +ifneq (,$(CXX))
> vpath c++-types.data $(+sysdep_dirs)
>
> $(objpfx)c++-types-check.out: c++-types.data scripts/check-c++-types.sh
>
This is the wrong way to fix this. You've hidden the failure :-(
Please see:
https://sourceware.org/ml/libc-alpha/2015-08/msg01280.html
https://sourceware.org/ml/libc-alpha/2015-08/msg01284.html
--
Cheers,
Carlos.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [COMMITTED PATCH] Fix c++-types-check conditionalization.
2016-03-08 17:25 ` Carlos O'Donell
@ 2016-03-08 20:37 ` Roland McGrath
0 siblings, 0 replies; 4+ messages in thread
From: Roland McGrath @ 2016-03-08 20:37 UTC (permalink / raw)
To: Carlos O'Donell; +Cc: GNU C. Library, Tulio Magno Quites Machado Filho
I correctly fixed the bug in the conditionalization. I did not fix the
separate issue of this test not supporting UNSUPPORTED (which I had indeed
forgotten about). Feel free to fix that one.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-03-08 20:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-04 21:25 [COMMITTED PATCH] Fix c++-types-check conditionalization Roland McGrath
2016-03-07 20:58 ` Tulio Magno Quites Machado Filho
2016-03-08 17:25 ` Carlos O'Donell
2016-03-08 20:37 ` Roland McGrath
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).