public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] Support --enable-hardcoded-path-in-tests in benchtests
@ 2016-03-07 20:37 H.J. Lu
  2016-03-08  5:54 ` Siddhesh Poyarekar
  0 siblings, 1 reply; 2+ messages in thread
From: H.J. Lu @ 2016-03-07 20:37 UTC (permalink / raw)
  To: GNU C Library

benchtests should use $(test-via-rtld-prefix) and $(+link-tests) like
other glibc tests.

OK for master?

H.J.
---
	[BZ #19783]
	* benchtests/Makefile (run-bench): Replace $(rtld-prefix) with
	$(test-via-rtld-prefix).
	($(binaries-bench)): Replace $(+link) with $(+link-tests).
---
 benchtests/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/benchtests/Makefile b/benchtests/Makefile
index 2b553f8..a37d666 100644
--- a/benchtests/Makefile
+++ b/benchtests/Makefile
@@ -118,7 +118,7 @@ bench-deps := bench-skeleton.c bench-timing.h Makefile
 
 run-bench = $(test-wrapper-env) \
 	    $(run-program-env) \
-	    $($*-ENV) $(rtld-prefix) $${run}
+	    $($*-ENV) $(test-via-rtld-prefix) $${run}
 
 timing-type := $(objpfx)bench-timing-type
 
@@ -172,7 +172,7 @@ $(timing-type) $(binaries-bench) $(binaries-benchset) \
 	$(binaries-bench-malloc): %: %.o $(objpfx)json-lib.o \
   $(sort $(filter $(common-objpfx)lib%,$(link-libc))) \
   $(addprefix $(csu-objpfx),start.o) $(+preinit) $(+postinit)
-	$(+link)
+	$(+link-tests)
 
 $(objpfx)bench-%.c: %-inputs $(bench-deps)
 	{ if [ -n "$($*-INCLUDE)" ]; then \
-- 
2.5.0

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Support --enable-hardcoded-path-in-tests in benchtests
  2016-03-07 20:37 [PATCH] Support --enable-hardcoded-path-in-tests in benchtests H.J. Lu
@ 2016-03-08  5:54 ` Siddhesh Poyarekar
  0 siblings, 0 replies; 2+ messages in thread
From: Siddhesh Poyarekar @ 2016-03-08  5:54 UTC (permalink / raw)
  To: H.J. Lu; +Cc: GNU C Library

On Mon, Mar 07, 2016 at 12:37:23PM -0800, H.J. Lu wrote:
> benchtests should use $(test-via-rtld-prefix) and $(+link-tests) like
> other glibc tests.
> 
> OK for master?

Yes.

Thanks,
Siddhesh

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-03-08  5:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-07 20:37 [PATCH] Support --enable-hardcoded-path-in-tests in benchtests H.J. Lu
2016-03-08  5:54 ` Siddhesh Poyarekar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).