From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 78083 invoked by alias); 8 Mar 2016 23:37:42 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 78073 invoked by uid 89); 8 Mar 2016 23:37:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.0 required=5.0 tests=BAYES_20,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=imply, datetime, __time__, nscd_stat.c X-HELO: smtp.gentoo.org Date: Tue, 08 Mar 2016 23:37:00 -0000 From: Mike Frysinger To: Aurelien Jarno Cc: libc-alpha@sourceware.org Subject: Re: [PATCH] nscd_stat.c: make the build reproducible Message-ID: <20160308233738.GP6588@vapier.lan> Mail-Followup-To: Aurelien Jarno , libc-alpha@sourceware.org References: <1457456791-17402-1-git-send-email-aurelien@aurel32.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="/1RY4l6R+cI/ZU5B" Content-Disposition: inline In-Reply-To: <1457456791-17402-1-git-send-email-aurelien@aurel32.net> X-SW-Source: 2016-03/txt/msg00253.txt.bz2 --/1RY4l6R+cI/ZU5B Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 621 On 08 Mar 2016 18:06, Aurelien Jarno wrote: > nscd_stat.c uses the __DATE__ and __TIME__ macros to make sure the > client and the server use the same format. This prevents reproducible > builds and fails to build with -Werror=3Ddate-time. In addition another > build of the same file a bit later does not necessary imply a change > in the format. >=20 > Instead compute a checksum of the file in the Makefile and pass it to > the preprocessor with the -D option. Use the md5sum command limited to > 20 characters to avoid changing the structure size. this doesn't take into consideration the HAVE_SELINUX knob ... -mike --/1RY4l6R+cI/ZU5B Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJW32JCAAoJEEFjO5/oN/WBT8wQAL8QPwJDGkzlluuQhzuwG3sd Tm0RGNvJPnD1JAUhO6Kkzc62uF+nL4TdxFALPmjGDKmdXDWgyvHeikO8Wp6zRzCp eqvz5x0DiRXdLC05kWPPoAeog2o4vc5mXxOny8sZQqVR27A4WgCNFla0o1IF9hX0 qtb8YjfWm9y2KULLpsjMZDPqQuv55tkzCRGlfweldLh2GlrHPV8SpZqmTAFocLki sw46ApAPBBOtportCCpZ+7kqtFKjBaVmSRvwaEpv0hAJuOZ69WinbfJ5EwW6B9MW /0SA7u/LoedIex7nwvOigGTgwsvsGz8RPorfZNwuqqdCbseqIpzpqcnlBzvMJ62X 5nFNzGgqRV4Z46xHZLdlpyWUo+/+IeuuB39U3ILMuWOZsBI1XkRf8QM+Wa1jRxjO +RSl+cHXpgE2CAGc6ik7H+XFwNsBt6Gd0mNjAIMJZf5kVSCOtNGGXbXdBAHaxVEP +6tohEwtHdz7Gge9No/wOJyy+p4K7aav0cjJFsbO9npfG4QksBZp0h7LA67ASgO2 9py9X/o5dfYh11v9x4InIUdda+U91J/flaMzXuY1IAbbFi0Wac1ejYOnx6BO94KV qmcPd+iYObkjYRg+2+bf5iwf/So4eox4J8IMgZzTL0drMKp/9MFpMvMVk4cxKYlo QFrStcldKsonjk2bL41v =QNTG -----END PGP SIGNATURE----- --/1RY4l6R+cI/ZU5B--