From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23340 invoked by alias); 9 Mar 2016 07:54:26 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 23329 invoked by uid 89); 9 Mar 2016 07:54:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=1.8 required=5.0 tests=BAYES_50,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=U*aurelien, sk:aurelie, aurelien@aurel32.net, D*aurel32.net X-HELO: hall.aurel32.net Date: Wed, 09 Mar 2016 07:54:00 -0000 From: Aurelien Jarno To: libc-alpha@sourceware.org Subject: Re: [PATCH] nscd_stat.c: make the build reproducible Message-ID: <20160309075403.GA2444@aurel32.net> Mail-Followup-To: libc-alpha@sourceware.org References: <1457456791-17402-1-git-send-email-aurelien@aurel32.net> <20160308233738.GP6588@vapier.lan> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ibTvN161/egqYuK8" Content-Disposition: inline In-Reply-To: <20160308233738.GP6588@vapier.lan> User-Agent: Mutt/1.5.24 (2015-08-30) X-SW-Source: 2016-03/txt/msg00262.txt.bz2 --ibTvN161/egqYuK8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 925 On 2016-03-08 18:37, Mike Frysinger wrote: > On 08 Mar 2016 18:06, Aurelien Jarno wrote: > > nscd_stat.c uses the __DATE__ and __TIME__ macros to make sure the > > client and the server use the same format. This prevents reproducible > > builds and fails to build with -Werror=3Ddate-time. In addition another > > build of the same file a bit later does not necessary imply a change > > in the format. > >=20 > > Instead compute a checksum of the file in the Makefile and pass it to > > the preprocessor with the -D option. Use the md5sum command limited to > > 20 characters to avoid changing the structure size. >=20 > this doesn't take into consideration the HAVE_SELINUX knob ... Correct. Back to the design board, I'll try to provide a new solution. Don't hesitate to tell if you have ideas. --=20 Aurelien Jarno GPG: 4096R/1DDD8C9B aurelien@aurel32.net http://www.aurel32.net --ibTvN161/egqYuK8 Content-Type: application/pgp-signature; name="signature.asc" Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJW39abAAoJELqceAYd3Yyb42UP/iLnO2Dw2nAYuM7ZT6w5AMrF KfB/sbaN7OsKXe3W7GmNML0Sk3AlGR3f7Xqd9K1H1lwa2itPNL8bFBaBZyeVcjDn 3y3IfYUbt5U8QgVnUqmZbiEGoJ6ko97TofARQr+WJRwwladbjPcynVWH2jsVFTMy +JQwbX+2zev7wJWetdwRQTGEOWF5ZWm6ufYd+QcYE2x0bfaYBB3PEYVQV9kHQv11 dkKqSqICArhTxDAovuMF5u2F219o/6die07XNfGu1ySS//dx7ms3kimgI+5+KHae 3eeMTOP+n7mnX/H1PnE7iSYtmwUprD3AxM4euK+W2dsf+XiTh0ZUDQ5gmuJ9dm5B 0amg6u18cwgQviw+9LBCS6VZs1Bl+UXGpYiMf9CuHpNa1PuCk66RyZR0gJ43sCRd mybcqn6tCspaQbVVJfTze2twfOJFu0mtNT8tY9bTEMYNXR10gEIIf7cIZZyVvGot r9wTjOlhgfHBBmHGk0P7zX/z7jTXVp61iMjv2SeWEeEwMi2WDjqMwXgS4tCFTw82 rDyHXaOve0YCRXuU5jOJWk64BJK5nPBAxVNEdx2MqHGNdPkWPfADvkgTuKcSAA11 EHuRwu5QjV5Hq5UGNrBLRetudiUW406ajsiI732NeYfM+gqlCbz3SoA12ACHn3+F 9nKucppbASnMGzQZoat1 =kV8b -----END PGP SIGNATURE----- --ibTvN161/egqYuK8--