From: Roland McGrath <roland@hack.frob.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH 1/2] Add _arch_/_cpu_ to index_*/bit_* in x86 cpu-features.h
Date: Fri, 11 Mar 2016 21:47:00 -0000 [thread overview]
Message-ID: <20160311214735.4CAE52C3C21@topped-with-meat.com> (raw)
In-Reply-To: H.J. Lu's message of Sunday, 6 March 2016 07:46:49 -0800 <CAMe9rOqmnA8TOOEo_KbxYnxaDDvzEcb+hqLHwK=dZ5J75W8d5Q@mail.gmail.com>
Your post didn't mention testing done. Every post of a patch you want
actually considered for approval should explicitly say what testing you
have done, and nobody should approve if you haven't clearly tested it.
Any patch that has been waiting for more than a day or two needs
explicit re-testing (and report of doing so) before you land it. This
change broke the 'make check' build on Linux/x86_64. There is really no
excuse for that.
next prev parent reply other threads:[~2016-03-11 21:47 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-03 23:52 H.J. Lu
2016-03-03 23:52 ` [PATCH 2/2] Use HAS_ARCH_FEATURE with Fast_Rep_String H.J. Lu
2016-03-06 15:48 ` H.J. Lu
2016-03-06 15:46 ` [PATCH 1/2] Add _arch_/_cpu_ to index_*/bit_* in x86 cpu-features.h H.J. Lu
2016-03-10 13:25 ` H.J. Lu
2016-03-11 21:47 ` Roland McGrath [this message]
2016-03-11 21:50 ` H.J. Lu
2016-03-11 22:00 ` Roland McGrath
2016-03-11 22:20 ` H.J. Lu
2016-03-11 22:29 ` Roland McGrath
2016-03-11 22:41 ` H.J. Lu
2016-03-11 22:49 ` Florian Weimer
2016-03-11 22:55 ` Roland McGrath
2016-03-11 23:00 ` H.J. Lu
2016-03-11 23:06 ` Florian Weimer
2016-03-11 23:09 ` H.J. Lu
2016-03-11 23:16 ` Roland McGrath
2016-03-25 10:40 ` Florian Weimer
2016-03-28 22:16 ` Roland McGrath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160311214735.4CAE52C3C21@topped-with-meat.com \
--to=roland@hack.frob.com \
--cc=hjl.tools@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).