From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 113570 invoked by alias); 11 Mar 2016 21:47:40 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 112606 invoked by uid 89); 11 Mar 2016 21:47:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 spammy=Every X-HELO: topped-with-meat.com MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit From: Roland McGrath To: "H.J. Lu" Cc: GNU C Library Subject: Re: [PATCH 1/2] Add _arch_/_cpu_ to index_*/bit_* in x86 cpu-features.h In-Reply-To: H.J. Lu's message of Sunday, 6 March 2016 07:46:49 -0800 References: <1457049161-13783-1-git-send-email-hjl.tools@gmail.com> Message-Id: <20160311214735.4CAE52C3C21@topped-with-meat.com> Date: Fri, 11 Mar 2016 21:47:00 -0000 X-CMAE-Score: 0 X-CMAE-Analysis: v=2.1 cv=RZ8DVTdv c=1 sm=1 tr=0 a=WkljmVdYkabdwxfqvArNOQ==:117 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=kj9zAlcOel0A:10 a=DPGrczrlJvqGCnK8BowA:9 a=CjuIK1q_8ugA:10 a=YlFWUgoyg2QA:10 X-SW-Source: 2016-03/txt/msg00352.txt.bz2 Your post didn't mention testing done. Every post of a patch you want actually considered for approval should explicitly say what testing you have done, and nobody should approve if you haven't clearly tested it. Any patch that has been waiting for more than a day or two needs explicit re-testing (and report of doing so) before you land it. This change broke the 'make check' build on Linux/x86_64. There is really no excuse for that.