* [PATCH] locales: an_ES: fix lang_ab value
@ 2016-02-20 4:38 Mike Frysinger
2016-02-25 20:19 ` Mike Frysinger
2016-02-29 16:45 ` Aurelien Jarno
0 siblings, 2 replies; 6+ messages in thread
From: Mike Frysinger @ 2016-02-20 4:38 UTC (permalink / raw)
To: libc-alpha
Aragonese is classified as "an" so set it.
---
localedata/locales/an_ES | 1 +
1 file changed, 1 insertion(+)
diff --git a/localedata/locales/an_ES b/localedata/locales/an_ES
index cc18c6b..e6d00f3 100644
--- a/localedata/locales/an_ES
+++ b/localedata/locales/an_ES
@@ -134,6 +134,7 @@ postal_fmt "<U0025><U0066><U0025><U004E><U0025><U0061><U0025><U004E>/
country_ab2 "<U0045><U0053>"
country_ab3 "<U0045><U0053><U0050>"
country_num 724
+lang_ab "<U0041><U004E>"
% E
country_car "<U0045>"
% aragonés
--
2.6.2
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] locales: an_ES: fix lang_ab value
2016-02-20 4:38 [PATCH] locales: an_ES: fix lang_ab value Mike Frysinger
@ 2016-02-25 20:19 ` Mike Frysinger
2016-02-29 16:45 ` Aurelien Jarno
1 sibling, 0 replies; 6+ messages in thread
From: Mike Frysinger @ 2016-02-25 20:19 UTC (permalink / raw)
To: libc-alpha
[-- Attachment #1: Type: text/plain, Size: 105 bytes --]
On 19 Feb 2016 23:38, Mike Frysinger wrote:
> Aragonese is classified as "an" so set it.
ping ...
-mike
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] locales: an_ES: fix lang_ab value
2016-02-20 4:38 [PATCH] locales: an_ES: fix lang_ab value Mike Frysinger
2016-02-25 20:19 ` Mike Frysinger
@ 2016-02-29 16:45 ` Aurelien Jarno
2016-03-16 4:55 ` Carlos O'Donell
1 sibling, 1 reply; 6+ messages in thread
From: Aurelien Jarno @ 2016-02-29 16:45 UTC (permalink / raw)
To: Mike Frysinger; +Cc: libc-alpha
On 2016-02-19 23:38, Mike Frysinger wrote:
> Aragonese is classified as "an" so set it.
> ---
> localedata/locales/an_ES | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/localedata/locales/an_ES b/localedata/locales/an_ES
> index cc18c6b..e6d00f3 100644
> --- a/localedata/locales/an_ES
> +++ b/localedata/locales/an_ES
> @@ -134,6 +134,7 @@ postal_fmt "<U0025><U0066><U0025><U004E><U0025><U0061><U0025><U004E>/
> country_ab2 "<U0045><U0053>"
> country_ab3 "<U0045><U0053><U0050>"
> country_num 724
> +lang_ab "<U0041><U004E>"
> % E
> country_car "<U0045>"
> % aragonés
This is correct
--
Aurelien Jarno GPG: 4096R/1DDD8C9B
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] locales: an_ES: fix lang_ab value
2016-02-29 16:45 ` Aurelien Jarno
@ 2016-03-16 4:55 ` Carlos O'Donell
2016-03-16 18:44 ` Mike Frysinger
0 siblings, 1 reply; 6+ messages in thread
From: Carlos O'Donell @ 2016-03-16 4:55 UTC (permalink / raw)
To: Mike Frysinger, libc-alpha, Aurelien Jarno
On 02/29/2016 10:46 AM, Aurelien Jarno wrote:
> On 2016-02-19 23:38, Mike Frysinger wrote:
>> Aragonese is classified as "an" so set it.
>> ---
>> localedata/locales/an_ES | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/localedata/locales/an_ES b/localedata/locales/an_ES
>> index cc18c6b..e6d00f3 100644
>> --- a/localedata/locales/an_ES
>> +++ b/localedata/locales/an_ES
>> @@ -134,6 +134,7 @@ postal_fmt "<U0025><U0066><U0025><U004E><U0025><U0061><U0025><U004E>/
>> country_ab2 "<U0045><U0053>"
>> country_ab3 "<U0045><U0053><U0050>"
>> country_num 724
>> +lang_ab "<U0041><U004E>"
>> % E
>> country_car "<U0045>"
>> % aragonés
>
> This is correct
>
This is not correct. You must use an abbreviation which matches
exactly in case with ISO 639 names.
This commit:
~~~
commit 75aa31de9fb79986e5424f80dd152f684a3a16b1
Author: Mike Frysinger <vapier@gentoo.org>
Date: Fri Feb 19 23:25:03 2016 -0500
localedata: an_ES: fix lang_ab value
Aragonese is classified as "an" so set it.
~~~
Causes the following failure for me in auto-sync'd Fedora Rawhide:
an_ES.UTF-8...LC_ADDRESS: language abbreviation `AN' not defined
Makefile:205: recipe for target 'install-an_ES.UTF-8/UTF-8' failed
make[2]: *** [install-an_ES.UTF-8/UTF-8] Error 1
make[2]: Leaving directory '/home/carlos/src/glibc/localedata'
Makefile:421: recipe for target 'localedata/install-locales' failed
make[1]: *** [localedata/install-locales] Error 2
make[1]: Leaving directory '/home/carlos/src/glibc'
Makefile:9: recipe for target 'localedata/install-locales' failed
make: *** [localedata/install-locales] Error 2
I believe the fix should be to use lowercase 'an':
diff --git a/localedata/locales/an_ES b/localedata/locales/an_ES
index e6d00f3..202732d 100644
--- a/localedata/locales/an_ES
+++ b/localedata/locales/an_ES
@@ -134,7 +134,7 @@ postal_fmt "<U0025><U0066><U0025><U004E><U0025><U0061><U0025><U004E>/
country_ab2 "<U0045><U0053>"
country_ab3 "<U0045><U0053><U0050>"
country_num 724
-lang_ab "<U0041><U004E>"
+lang_ab "<U0061><U006E>"
% E
country_car "<U0045>"
% aragonés
---
That is to say that the language abbreviation must be lowercase
and thus match locale/iso-639.def.
Please make sure you run:
`make localedata/install-locales DESTDIR=/tmp/glibc-install`
as a sanity check for these kinds of changes.
--
Cheers,
Carlos.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] locales: an_ES: fix lang_ab value
2016-03-16 4:55 ` Carlos O'Donell
@ 2016-03-16 18:44 ` Mike Frysinger
2016-03-17 14:40 ` Carlos O'Donell
0 siblings, 1 reply; 6+ messages in thread
From: Mike Frysinger @ 2016-03-16 18:44 UTC (permalink / raw)
To: Carlos O'Donell; +Cc: libc-alpha, Aurelien Jarno
[-- Attachment #1: Type: text/plain, Size: 1370 bytes --]
On 16 Mar 2016 00:54, Carlos O'Donell wrote:
> On 02/29/2016 10:46 AM, Aurelien Jarno wrote:
> > On 2016-02-19 23:38, Mike Frysinger wrote:
> >> Aragonese is classified as "an" so set it.
> >> ---
> >> localedata/locales/an_ES | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >> diff --git a/localedata/locales/an_ES b/localedata/locales/an_ES
> >> index cc18c6b..e6d00f3 100644
> >> --- a/localedata/locales/an_ES
> >> +++ b/localedata/locales/an_ES
> >> @@ -134,6 +134,7 @@ postal_fmt "<U0025><U0066><U0025><U004E><U0025><U0061><U0025><U004E>/
> >> country_ab2 "<U0045><U0053>"
> >> country_ab3 "<U0045><U0053><U0050>"
> >> country_num 724
> >> +lang_ab "<U0041><U004E>"
> >> % E
> >> country_car "<U0045>"
> >> % aragonés
> >
> > This is correct
>
> This is not correct. You must use an abbreviation which matches
> exactly in case with ISO 639 names.
i didn't intend to use uppercase. i'll push your fix. i've also
updated my linter to check for case here.
> Please make sure you run:
> `make localedata/install-locales DESTDIR=/tmp/glibc-install`
> as a sanity check for these kinds of changes.
i'd been running localedef on all the files when making changes, but
looks like i had a bug in my script and was using the wrong datastore.
i've fixed that now and it does show this error too.
-mike
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] locales: an_ES: fix lang_ab value
2016-03-16 18:44 ` Mike Frysinger
@ 2016-03-17 14:40 ` Carlos O'Donell
0 siblings, 0 replies; 6+ messages in thread
From: Carlos O'Donell @ 2016-03-17 14:40 UTC (permalink / raw)
To: libc-alpha, Aurelien Jarno
On 03/16/2016 02:44 PM, Mike Frysinger wrote:
> On 16 Mar 2016 00:54, Carlos O'Donell wrote:
>> On 02/29/2016 10:46 AM, Aurelien Jarno wrote:
>>> On 2016-02-19 23:38, Mike Frysinger wrote:
>>>> Aragonese is classified as "an" so set it.
>>>> ---
>>>> localedata/locales/an_ES | 1 +
>>>> 1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/localedata/locales/an_ES b/localedata/locales/an_ES
>>>> index cc18c6b..e6d00f3 100644
>>>> --- a/localedata/locales/an_ES
>>>> +++ b/localedata/locales/an_ES
>>>> @@ -134,6 +134,7 @@ postal_fmt "<U0025><U0066><U0025><U004E><U0025><U0061><U0025><U004E>/
>>>> country_ab2 "<U0045><U0053>"
>>>> country_ab3 "<U0045><U0053><U0050>"
>>>> country_num 724
>>>> +lang_ab "<U0041><U004E>"
>>>> % E
>>>> country_car "<U0045>"
>>>> % aragonés
>>>
>>> This is correct
>>
>> This is not correct. You must use an abbreviation which matches
>> exactly in case with ISO 639 names.
>
> i didn't intend to use uppercase. i'll push your fix. i've also
> updated my linter to check for case here.
>
>> Please make sure you run:
>> `make localedata/install-locales DESTDIR=/tmp/glibc-install`
>> as a sanity check for these kinds of changes.
>
> i'd been running localedef on all the files when making changes, but
> looks like i had a bug in my script and was using the wrong datastore.
> i've fixed that now and it does show this error too.
Awesome. Thanks for fixing it!
--
Cheers,
Carlos.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-03-17 14:40 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-20 4:38 [PATCH] locales: an_ES: fix lang_ab value Mike Frysinger
2016-02-25 20:19 ` Mike Frysinger
2016-02-29 16:45 ` Aurelien Jarno
2016-03-16 4:55 ` Carlos O'Donell
2016-03-16 18:44 ` Mike Frysinger
2016-03-17 14:40 ` Carlos O'Donell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).