From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12087 invoked by alias); 2 Apr 2016 23:40:50 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 12071 invoked by uid 89); 2 Apr 2016 23:40:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=algo X-HELO: gate.crashing.org Date: Sat, 02 Apr 2016 23:40:00 -0000 From: Segher Boessenkool To: "Paul E. Murphy" Cc: "libc-alpha@sourceware.org" , Tulio Magno Quites Machado Filho Subject: Re: [PATCHv2] powerpc: Add optimized P8 strspn Message-ID: <20160402234040.GA17716@gate.crashing.org> References: <56FC0008.7030302@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56FC0008.7030302@linux.vnet.ibm.com> User-Agent: Mutt/1.4.2.3i X-SW-Source: 2016-04/txt/msg00031.txt.bz2 Hi Paul, Sorry for not reviewing this earlier. Some minor things; this is not a full review. > +++ b/sysdeps/powerpc/powerpc64/multiarch/strspn.c > @@ -0,0 +1,35 @@ > +/* Multiple versions of strspn. PowerPC64 version. Two spaces after full stop. > +++ b/sysdeps/powerpc/powerpc64/power8/strspn.S > +/* size_t [r3] strspn (const char *string [r3], > + const char *needleAccept [r4] */ Missing ")". > + lvsr v11, r0, r3 That is 0, not r0. > + lvx v0, r0, r3 /* Note, unaligned load ignores lower bits. */ Same for lvx. Interesting algo :-) Segher