From: Mike Frysinger <vapier@gentoo.org>
To: Khem Raj <raj.khem@gmail.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH V3] When disabling SSE, make sure -fpmath is not set to use SSE either
Date: Sun, 03 Apr 2016 02:16:00 -0000 [thread overview]
Message-ID: <20160403021612.GV6588@vapier.lan> (raw)
In-Reply-To: <1459439112-30153-1-git-send-email-raj.khem@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 607 bytes --]
On 31 Mar 2016 08:45, Khem Raj wrote:
> # Make sure no code in ld.so uses mm/xmm/ymm/zmm registers on i386 since
> # the first 3 mm/xmm/ymm/zmm registers are used to pass vector parameters
> # which must be preserved.
> +# with SSE disabled, ensure -fpmath is not set to use sse either, this
> +# avoids below compiler diagnostic
> +# warning: SSE instruction set disabled, using 387 arithmetics
> +# which is treated as error with -Werror
the flag change looks fine, but this comment seems excessive.
i think it should just read:
# With SSE disabled, ensure -fpmath is not set to use sse either.
-mike
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2016-04-03 2:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-31 15:45 Khem Raj
2016-04-03 2:16 ` Mike Frysinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160403021612.GV6588@vapier.lan \
--to=vapier@gentoo.org \
--cc=libc-alpha@sourceware.org \
--cc=raj.khem@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).